Serve and patch Hook as an ISO during runtime #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
requested changes
Nov 7, 2024
rahulbabu95
force-pushed
the
patch-iso-runtime
branch
2 times, most recently
from
d70fb28 to
0c7f8e1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
====================================
- Coverage 51% 49% -2%
====================================
Files 26 27 +1
Lines 2757 2935 +178
====================================
+ Hits 1412 1464 +52
- Misses 1305 1429 +124
- Partials 40 42 +2 ☔ View full report in Codecov by Sentry. |
jacobweinstock
requested changes
Nov 13, 2024
Signed-off-by: Rahul Ganesh <[email protected]>
rahulbabu95
force-pushed
the
patch-iso-runtime
branch
from
4716c64 to
e491a35
Compare
jacobweinstock
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the ability in Smee to serve Hook as an ISO file through HTTP and also patch it with all the necessary dynamic information needed to connect with a Tink Server.
Why is this needed
Hook recently added an feature to support building it as an ISO file. This change leverages that feature to be able to serve and patch Hook as an ISO file. This will be needed to be able to get Tinkerbell stack running on L3 without any Layer 2 dependency.
How Has This Been Tested?
Built a custom smee image with above changes, and tested with that image and replacing the smee deployment of Tink stack on a k3d cluster with real hardware. Set the Hardware to boot from Virtual media mount and verified that the hardware was able to boot properly.
How are existing users impacted? What migration steps/scripts do we need?
ISO serving will not be enabled by default in the CLI and users have to explicitly set the 'iso-enabled' flag to make use of the feature. So as such the change will not have any impact on existing users.