Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to slog logr implementation: #552

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

jacobweinstock
Copy link
Member

Description

slog is one less import and by default provides improved time format and file, function, and line number attributes.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 49%. Comparing base (24e97c2) to head (f3a2ddf).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/smee/main.go 0% 23 Missing ⚠️
Additional details and impacted files
@@         Coverage Diff         @@
##           main   #552   +/-   ##
===================================
- Coverage    49%    49%   -1%     
===================================
  Files        27     27           
  Lines      2935   2951   +16     
===================================
- Hits       1464   1461    -3     
- Misses     1429   1447   +18     
- Partials     42     43    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

slog is one less import and by default
provides improved time format and file,
function, and line number attributes.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock merged commit 4e5c46c into tinkerbell:main Nov 19, 2024
4 of 5 checks passed
@jacobweinstock jacobweinstock deleted the use-slog branch November 19, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant