all: Go 1.21 support #3824

aykevl · 2023-07-06T10:02:48Z

Work in progress. The main thing that fails is encoding/json.

github-actions · 2023-07-06T10:29:03Z

Size difference with the dev branch:

Binary size difference

not the same command!
    go: downloading golang.org/x/text v0.3.6
    tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/wifinina/ntpclient/main.go
not the same command!
    go: downloading github.com/eclipse/paho.mqtt.golang v1.2.0
    tinygo build -size short -o ./build/test.hex -target=wioterminal ./examples/rtl8720dn/mqttsub/
 before   after   diff
  60748   60748      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/adt7410/main.go
   9768    9768      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/adxl345/main.go
  13372   13372      0   0.00%  tinygo build -size short -o ./build/test.hex -target=pybadge ./examples/amg88xx
   8896    8896      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/apa102/main.go
  11780   11780      0   0.00%  tinygo build -size short -o ./build/test.hex -target=nano-33-ble ./examples/apds9960/proximity/main.go
  10636   10636      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/apa102/itsybitsy-m0/main.go
   8140    8140      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/at24cx/main.go
   8484    8484      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/bh1750/main.go
   7708    7708      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/blinkm/main.go
  63192   63192      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/bmi160/main.go
  28064   28064      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/bmp180/main.go
  63260   63260      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/bmp280/main.go
  12432   12432      0   0.00%  tinygo build -size short -o ./build/test.hex -target=trinket-m0 ./examples/bmp388/main.go
   7724    7724      0   0.00%  tinygo build -size short -o ./build/test.hex -target=bluepill ./examples/ds1307/sram/main.go
  22052   22052      0   0.00%  tinygo build -size short -o ./build/test.hex -target=bluepill ./examples/ds1307/time/main.go
  68888   68888      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/ds3231/main.go
   4712    4712      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/easystepper/main.go
  24960   24960      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/espat/espconsole/main.go
  25160   25160      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/espat/esphub/main.go
  24968   24968      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/espat/espstation/main.go
  68640   68640      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/flash/console/spi
  64664   64664      0   0.00%  tinygo build -size short -o ./build/test.hex -target=pyportal ./examples/flash/console/qspi
   7072    7072      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/gc9a01/main.go
  68032   68032      0   0.00%  tinygo build -size short -o ./build/test.hex -target=feather-m0 ./examples/gps/i2c/main.go
  68444   68444      0   0.00%  tinygo build -size short -o ./build/test.hex -target=feather-m0 ./examples/gps/uart/main.go
   8576    8576      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/hcsr04/main.go
   5688    5688      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/hd44780/customchar/main.go
   5652    5652      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/hd44780/text/main.go
  10716   10716      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/hd44780i2c/main.go
  14792   14792      0   0.00%  tinygo build -size short -o ./build/test.hex -target=nano-33-ble ./examples/hts221/main.go
  15896   15896      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/hub75/main.go
  10220   10220      0   0.00%  tinygo build -size short -o ./build/test.hex -target=pyportal ./examples/ili9341/basic
  11024   11024      0   0.00%  tinygo build -size short -o ./build/test.hex -target=xiao ./examples/ili9341/basic
  29212   29212      0   0.00%  tinygo build -size short -o ./build/test.hex -target=pyportal ./examples/ili9341/pyportal_boing
  10248   10248      0   0.00%  tinygo build -size short -o ./build/test.hex -target=pyportal ./examples/ili9341/scroll
  11100   11100      0   0.00%  tinygo build -size short -o ./build/test.hex -target=xiao ./examples/ili9341/scroll
 267468  267468      0   0.00%  tinygo build -size short -o ./build/test.hex -target=pyportal ./examples/ili9341/slideshow
  12124   12124      0   0.00%  tinygo build -size short -o ./build/test.hex -target=circuitplay-express ./examples/lis3dh/main.go
  14148   14148      0   0.00%  tinygo build -size short -o ./build/test.hex -target=nano-33-ble ./examples/lps22hb/main.go
  26156   26156      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/lsm303agr/main.go
  12620   12620      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/lsm6ds3/main.go
  11084   11084      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/mag3110/main.go
  10272   10272      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/mcp23017/main.go
  10704   10704      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/mcp23017-multiple/main.go
   9996    9996      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/mcp3008/main.go
  66816   66816      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/mcp2515/main.go
  21968   21968      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/microbitmatrix/main.go
  22024   22024      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit-v2 ./examples/microbitmatrix/main.go
   8636    8636      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/mma8653/main.go
   8420    8420      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/mpu6050/main.go
  74928   74928      0   0.00%  tinygo build -size short -o ./build/test.hex -target=p1am-100 ./examples/p1am/main.go
  12264   12264      0   0.00%  tinygo build -size short -o ./build/test.hex -target=pico ./examples/pca9685/main.go
   6112    6112      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/pcd8544/setbuffer/main.go
   5124    5124      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/pcd8544/setpixel/main.go
   2889    2889      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino ./examples/servo
   8092    8092      0   0.00%  tinygo build -size short -o ./build/test.hex -target=pybadge ./examples/shifter/main.go
  56340   56340      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/sht3x/main.go
  56312   56312      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/shtc3/main.go
   6452    6452      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/ssd1306/i2c_128x32/main.go
   5960    5960      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/ssd1306/spi_128x64/main.go
   5728    5728      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/ssd1331/main.go
   6420    6420      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/st7735/main.go
   6316    6316      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/st7789/main.go
  17368   17368      0   0.00%  tinygo build -size short -o ./build/test.hex -target=circuitplay-express ./examples/thermistor/main.go
  10284   10284      0   0.00%  tinygo build -size short -o ./build/test.hex -target=circuitplay-bluefruit ./examples/tone
  10952   10952      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/tm1637/main.go
   9536    9536      0   0.00%  tinygo build -size short -o ./build/test.hex -target=pyportal ./examples/touch/resistive/fourwire/main.go
  12532   12532      0   0.00%  tinygo build -size short -o ./build/test.hex -target=pyportal ./examples/touch/resistive/pyportal_touchpaint/main.go
  15852   15852      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/vl53l1x/main.go
  13876   13876      0   0.00%  tinygo build -size short -o ./build/test.hex -target=itsybitsy-m0 ./examples/vl6180x/main.go
   6484    6484      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/waveshare-epd/epd2in13/main.go
   6036    6036      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/waveshare-epd/epd2in13x/main.go
   6312    6312      0   0.00%  tinygo build -size short -o ./build/test.hex -target=microbit ./examples/waveshare-epd/epd4in2/main.go
 137260  137260      0   0.00%  go: downloading golang.org/x/text v0.3.6
 137268  137268      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/wifinina/udpstation/main.go
 137528  137528      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/wifinina/tcpclient/main.go
 137660  137660      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/wifinina/webclient/main.go
   7120    7120      0   0.00%  tinygo build -size short -o ./build/test.hex -target=circuitplay-express ./examples/ws2812
   5452    5452      0   0.00%  tinygo build -size short -o ./build/test.bin -target=m5stamp-c3          ./examples/ws2812
  61588   61588      0   0.00%  tinygo build -size short -o ./build/test.hex -target=feather-nrf52840 ./examples/is31fl3731/main.go
   1565    1565      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino   ./examples/ws2812
    896     896      0   0.00%  tinygo build -size short -o ./build/test.hex -target=digispark ./examples/ws2812
  32332   32332      0   0.00%  tinygo build -size short -o ./build/test.hex -target=trinket-m0 ./examples/bme280/main.go
  16816   16816      0   0.00%  tinygo build -size short -o ./build/test.hex -target=circuitplay-express ./examples/microphone/main.go
  11484   11484      0   0.00%  tinygo build -size short -o ./build/test.hex -target=circuitplay-express ./examples/buzzer/main.go
  13076   13076      0   0.00%  tinygo build -size short -o ./build/test.hex -target=trinket-m0 ./examples/veml6070/main.go
   7012    7012      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/l293x/simple/main.go
   8968    8968      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/l293x/speed/main.go
   6980    6980      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/l9110x/simple/main.go
   9524    9524      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/l9110x/speed/main.go
   7464    7464      0   0.00%  tinygo build -size short -o ./build/test.hex -target=nucleo-f103rb ./examples/shiftregister/main.go
   8336    8336      0   0.00%  tinygo build -size short -o ./build/test.hex -target=hifive1b ./examples/ssd1351/main.go
  13364   13364      0   0.00%  tinygo build -size short -o ./build/test.hex -target=circuitplay-express ./examples/lis2mdl/main.go
   8516    8516      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/max72xx/main.go
  77260   77260      0   0.00%  tinygo build -size short -o ./build/test.hex -target=feather-m0 ./examples/dht/main.go
  70732   70732      0   0.00%  tinygo build -size short -o ./build/test.hex -target=xiao ./examples/pcf8563/alarm/
   7492    7492      0   0.00%  tinygo build -size short -o ./build/test.hex -target=xiao ./examples/pcf8563/clkout/
  70404   70404      0   0.00%  tinygo build -size short -o ./build/test.hex -target=xiao ./examples/pcf8563/time/
  70668   70668      0   0.00%  tinygo build -size short -o ./build/test.hex -target=xiao ./examples/pcf8563/timer/
  12108   12108      0   0.00%  tinygo build -size short -o ./build/test.hex -target=pico ./examples/qmi8658c/main.go
   9024    9024      0   0.00%  tinygo build -size short -o ./build/test.hex -target=feather-m0 ./examples/ina260/main.go
   9432    9432      0   0.00%  tinygo build -size short -o ./build/test.hex -target=nucleo-l432kc ./examples/aht20/main.go
  72028   72028      0   0.00%  tinygo build -size short -o ./build/test.hex -target=feather-m4 ./examples/sdcard/console/
  82464   82464      0   0.00%  tinygo build -size short -o ./build/test.hex -target=wioterminal ./examples/rtl8720dn/webclient/
  71808   71808      0   0.00%  tinygo build -size short -o ./build/test.hex -target=wioterminal ./examples/rtl8720dn/webserver/
  98584   98584      0   0.00%  go: downloading github.com/eclipse/paho.mqtt.golang v1.2.0
  60304   60304      0   0.00%  tinygo build -size short -o ./build/test.hex -target=feather-m4 ./examples/i2csoft/adt7410/
  10400   10400      0   0.00%  tinygo build -size short -o ./build/test.elf -target=wioterminal ./examples/axp192/m5stack-core2-blinky/
   9076    9076      0   0.00%  tinygo build -size short -o ./build/test.uf2 -target=pico ./examples/xpt2046/main.go
  14572   14572      0   0.00%  tinygo build -size short -o ./build/test.hex -target=nucleo-wl55jc ./examples/sx126x/lora_rxtx/
  25884   25884      0   0.00%  tinygo build -size short -o ./build/test.uf2 -target=pico ./examples/ssd1289/main.go
  11348   11348      0   0.00%  tinygo build -size short -o ./build/test.hex -target=pico ./examples/irremote/main.go
  11340   11340      0   0.00%  tinygo build -size short -o ./build/test.hex -target=badger2040 ./examples/uc8151/main.go
  10468   10468      0   0.00%  tinygo build -size short -o ./build/test.uf2 -target=pico ./examples/scd4x/main.go
   8968    8968      0   0.00%  tinygo build -size short -o ./build/test.uf2 -target=circuitplay-express ./examples/makeybutton/main.go
   9732    9732      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/ds18b20/main.go
  81336   81336      0   0.00%  tinygo build -size short -o ./build/test.hex -target=nucleo-wl55jc ./examples/lora/lorawan/atcmd/
  15512   15512      0   0.00%  tinygo build -size short -o ./build/test.uf2 -target=pico ./examples/as560x/main.go
   9952    9952      0   0.00%  tinygo build -size short -o ./build/test.uf2 -target=pico ./examples/mpu6886/main.go
   8124    8124      0   0.00%  tinygo build -size short -o ./build/test.hex -target=arduino-nano33 ./examples/ttp229/main.go
3468754 3468754      0   0.00%   sum

deadprogram · 2023-07-07T10:16:27Z

@aykevl looks like actual fail in CircleCI https://app.circleci.com/pipelines/github/tinygo-org/tinygo/9801/workflows/61b4c44c-a10f-44c4-b5ed-d1f8603d4c4c/jobs/40999?invite=true#step-118-9

aykevl · 2023-07-07T14:06:17Z

@deadprogram fixed it, now this PR only needs a rebase after #3829 is merged to be ready.

deadprogram · 2023-07-07T16:21:53Z

@aykevl ready for rebase.

aykevl · 2023-07-08T11:34:30Z

I have updated CI for Linux, Windows, and macOS to use Go 1.21-rc2 instead of Go 1.20. This should be changed before the next release (see #3830).

It is now ready for review.

(Note that the last commit isn't really related to Go 1.21, but I added it because it's very small and generally useful).

deadprogram · 2023-07-08T12:07:38Z

@aykevl looks like a bunch of build errors

aykevl · 2023-07-08T18:09:19Z

Looks like this needs some more work:

There is a build failure on macOS (hopefully just a matter of updating the library).
It appears that our //go:wasmimport is a bit more strict than upstream.

aykevl · 2023-07-08T19:09:07Z

Fixed the issue with //go:wasmimport, so at least wasm works with Go 1.21.

I've reported the issue with macOS upstream: Doesn't compile with Go 1.21 on macOS bugst/go-serial#162
For Windows, it appears we need sync.OnceValue (seems to be new in Go 1.21).
For Linux, there is an issue with AVR that I need to investigate.

I'm glad I didn't wait until after the Go 1.21 release to investigate all these issues.

aykevl · 2023-07-09T21:23:54Z

Did a quick investigation into why AVR fails and it seems we are hitting this assert:

		s := conf.sizeof(T)
		assert(s == 4 || s == 8)

Looks like they made the assumption that all uintptr values are either 4 or 8 bytes in size.

aykevl · 2023-07-09T21:55:17Z

Reported the AVR bug upstream: golang/go#61249

deadprogram · 2023-07-17T16:58:42Z

I've reported the issue with macOS upstream: bugst/go-serial#162

Just submitted PR to correct that issue. See bugst/go-serial#163

deadprogram · 2023-07-18T17:48:19Z

Reported the AVR bug upstream: golang/go#61249

Fix for this has been merged:

golang/go@d983be9

UPDATE: it is not included in Go 1.21 rc3 however it looks like it was merged before the development version was switched to 1.22 so hopefully it will be included in the 1.21 final release.

deadprogram · 2023-07-18T18:13:24Z

For Windows, it appears we need sync.OnceValue (seems to be new in Go 1.21).

I have created PR #3837 to add these functions, and the Windows tests are now passing in that branch.

deadprogram · 2023-07-20T06:51:14Z

@aykevl PR #3838 has been merged into dev so please rebase this PR so we can verify it. Thanks!

aykevl · 2023-07-20T16:58:41Z

Rebased.

deadprogram · 2023-07-20T19:15:21Z

@aykevl looks like got further and now has this error in Windows smoketests:

ld.lld: error: undefined symbol: internal/godebug.registerMetric

See https://github.com/tinygo-org/tinygo/actions/runs/5613804410/job/15213684058#step:9:60

This is new in Go 1.21.

aykevl · 2023-07-26T11:41:31Z

Pushed a bunch of changes, hopefully it'll pass most tests now...

aykevl · 2023-07-26T13:06:40Z

Yes, looks like all expected tests pass! The only issue remaining is the AVR assert (which will be fixed in RC4 or the final release).

deadprogram · 2023-08-03T09:09:42Z

@aykevl looks like go1.21rc4 is now available! Can you please try switching this branch to use it to see if everything passes now?

This should not happen under normal circumstances. It can still happen when there is a mismatch between TinyGo version and the associated runtime, or while developing the compiler package.

aykevl · 2023-08-04T00:06:08Z

Great, I've updated the PR to use the -rc4 version.

deadprogram

All tests now passing! I think we can merge this now.... 🥳

deadprogram · 2023-08-04T09:59:06Z

Great work on this @aykevl now merging!

soypat · 2023-08-04T12:20:12Z

builder/config.go

@@ -27,7 +27,7 @@ func NewConfig(options *compileopts.Options) (*compileopts.Config, error) {
 	if err != nil {
 		return nil, err
 	}
-	if major != 1 || minor < 18 || minor > 20 {
+	if major != 1 || minor < 18 || minor > 21 {
 		// Note: when this gets updated, also update the Go compatibility matrix:
 		// https://github.com/tinygo-org/tinygo-site/blob/dev/content/docs/reference/go-compat-matrix.md
 		return nil, fmt.Errorf("requires go version 1.18 through 1.20, got go%d.%d", major, minor)


Missed a number s/1.20/1.21/

soypat

Minor nitpicks here and there, looks OK to me.

soypat · 2023-08-04T12:20:44Z

builder/config.go

@@ -27,7 +27,7 @@ func NewConfig(options *compileopts.Options) (*compileopts.Config, error) {
 	if err != nil {
 		return nil, err
 	}
-	if major != 1 || minor < 18 || minor > 20 {
+	if major != 1 || minor < 18 || minor > 21 {
 		// Note: when this gets updated, also update the Go compatibility matrix:
 		// https://github.com/tinygo-org/tinygo-site/blob/dev/content/docs/reference/go-compat-matrix.md
 		return nil, fmt.Errorf("requires go version 1.18 through 1.20, got go%d.%d", major, minor)


Missed a minor here s/1.20/1.21/l

soypat · 2023-08-04T12:23:24Z

compiler/testdata/go1.21.ll

@@ -0,0 +1,179 @@
+; ModuleID = 'go1.21.go'


Just curious here- how do you go about writing these .ll files? Are you comfortable enough writing them on your own or do you recourse to reference/help?

These files are generated using go test ./compiler -update.

soypat · 2023-08-04T12:25:46Z

src/internal/bytealg/bytealg.go

+	// Note: this does zero the buffer even though that's not necessary.
+	// For performance reasons we might want to change this (similar to the
+	// malloc function implemented in the runtime).


Should this start with a // TODO ? Thinking of ease of ctrl+f searching backburner items.

Does anyone every do that? I don't.
I typically use these kinds of comments as a hint to future me (or future someone else). With a TODO, I know something is really missing that should be implemented. In this case I didn't use a TODO because it's working as intended, just a bit slower than possible (and therefore if this shows up in a profiler there's a clear hint how to improve things).

aykevl force-pushed the go1.21 branch 2 times, most recently from 6edf612 to 1f96da7 Compare July 6, 2023 10:08

deadprogram added this to the v0.29.0 milestone Jul 6, 2023

aykevl force-pushed the go1.21 branch 2 times, most recently from 178dc05 to 6ed4fed Compare July 6, 2023 11:17

aykevl mentioned this pull request Jul 7, 2023

main: use go env instead of doing all detection manually #3745

Merged

aykevl force-pushed the go1.21 branch from cca9476 to 9d817c7 Compare July 7, 2023 13:48

aykevl mentioned this pull request Jul 7, 2023

reflect: add SetZero #3829

Merged

aykevl force-pushed the go1.21 branch from 23b24c8 to fa91988 Compare July 7, 2023 14:05

aykevl mentioned this pull request Jul 7, 2023

Use Go 1.21 in CI #3830

Closed

deadprogram requested a review from dgryski July 7, 2023 16:30

aykevl force-pushed the go1.21 branch 4 times, most recently from 48b73f9 to 3f9be84 Compare July 8, 2023 11:33

aykevl marked this pull request as ready for review July 8, 2023 11:33

aykevl force-pushed the go1.21 branch from 3f9be84 to 414bf1c Compare July 8, 2023 18:05

aykevl force-pushed the go1.21 branch from 414bf1c to 97fea1c Compare July 8, 2023 18:20

aykevl mentioned this pull request Jul 9, 2023

go/types: uncommon pointer sizes result in an assertion failure golang/go#61249

Closed

deadprogram mentioned this pull request Jul 18, 2023

sync: add OnceFunc(), OnceValue(), and OnceValues() functions as needed for Windows using Go 1.21 #3837

Closed

deadprogram mentioned this pull request Jul 19, 2023

sync: add implementation from upstream Go for OnceFunc, OnceValue, and OnceValues #3838

Merged

aykevl force-pushed the go1.21 branch from 97fea1c to f91aead Compare July 20, 2023 16:58

aykevl force-pushed the go1.21 branch from f91aead to 7d45430 Compare July 26, 2023 09:48

testing: add Testing function

ed38943

This is new in Go 1.21.

aykevl force-pushed the go1.21 branch from 7d45430 to 463650f Compare July 26, 2023 11:40

aykevl mentioned this pull request Jul 31, 2023

modules: temporarily replace go.bug.st/serial with @deadprogram fork #3843

Closed

aykevl added 5 commits August 4, 2023 02:02

all: Go 1.21 support

8755bcc

compiler: add min and max builtin support

9b5619d

compiler: implement clear builtin for slices

db0a706

compiler: implement clear builtin for maps

8cf55d0

compiler: improve panic message when a runtime call is unavailable

be39e9c

This should not happen under normal circumstances. It can still happen when there is a mismatch between TinyGo version and the associated runtime, or while developing the compiler package.

aykevl force-pushed the go1.21 branch from 463650f to be39e9c Compare August 4, 2023 00:02

deadprogram approved these changes Aug 4, 2023

View reviewed changes

deadprogram merged commit 62294fe into dev Aug 4, 2023
22 checks passed

deadprogram deleted the go1.21 branch August 4, 2023 09:59

soypat reviewed Aug 4, 2023

View reviewed changes

deadprogram mentioned this pull request Aug 9, 2023

builder: update message for max supported Go version #3859

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all: Go 1.21 support #3824

all: Go 1.21 support #3824

aykevl commented Jul 6, 2023

github-actions bot commented Jul 6, 2023 •

edited

Loading

deadprogram commented Jul 7, 2023

aykevl commented Jul 7, 2023

deadprogram commented Jul 7, 2023

aykevl commented Jul 8, 2023 •

edited

Loading

deadprogram commented Jul 8, 2023

aykevl commented Jul 8, 2023

aykevl commented Jul 8, 2023 •

edited

Loading

aykevl commented Jul 9, 2023

aykevl commented Jul 9, 2023

deadprogram commented Jul 17, 2023

deadprogram commented Jul 18, 2023 •

edited

Loading

deadprogram commented Jul 18, 2023

deadprogram commented Jul 20, 2023

aykevl commented Jul 20, 2023

deadprogram commented Jul 20, 2023

aykevl commented Jul 26, 2023

aykevl commented Jul 26, 2023 •

edited

Loading

deadprogram commented Aug 3, 2023

aykevl commented Aug 4, 2023

deadprogram left a comment

deadprogram commented Aug 4, 2023

soypat Aug 4, 2023

soypat left a comment

soypat Aug 4, 2023

soypat Aug 4, 2023

aykevl Aug 4, 2023

soypat Aug 4, 2023

aykevl Aug 11, 2023

all: Go 1.21 support #3824

all: Go 1.21 support #3824

Conversation

aykevl commented Jul 6, 2023

github-actions bot commented Jul 6, 2023 • edited Loading

deadprogram commented Jul 7, 2023

aykevl commented Jul 7, 2023

deadprogram commented Jul 7, 2023

aykevl commented Jul 8, 2023 • edited Loading

deadprogram commented Jul 8, 2023

aykevl commented Jul 8, 2023

aykevl commented Jul 8, 2023 • edited Loading

aykevl commented Jul 9, 2023

aykevl commented Jul 9, 2023

deadprogram commented Jul 17, 2023

deadprogram commented Jul 18, 2023 • edited Loading

deadprogram commented Jul 18, 2023

deadprogram commented Jul 20, 2023

aykevl commented Jul 20, 2023

deadprogram commented Jul 20, 2023

aykevl commented Jul 26, 2023

aykevl commented Jul 26, 2023 • edited Loading

deadprogram commented Aug 3, 2023

aykevl commented Aug 4, 2023

deadprogram left a comment

Choose a reason for hiding this comment

deadprogram commented Aug 4, 2023

soypat Aug 4, 2023

Choose a reason for hiding this comment

soypat left a comment

Choose a reason for hiding this comment

soypat Aug 4, 2023

Choose a reason for hiding this comment

soypat Aug 4, 2023

Choose a reason for hiding this comment

aykevl Aug 4, 2023

Choose a reason for hiding this comment

soypat Aug 4, 2023

Choose a reason for hiding this comment

aykevl Aug 11, 2023

Choose a reason for hiding this comment

github-actions bot commented Jul 6, 2023 •

edited

Loading

aykevl commented Jul 8, 2023 •

edited

Loading

aykevl commented Jul 8, 2023 •

edited

Loading

deadprogram commented Jul 18, 2023 •

edited

Loading

aykevl commented Jul 26, 2023 •

edited

Loading