TINY-11431: Add chrome clipboardPermission handle #153
+103
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpyder
requested changes
Jan 23, 2025
README.md
Outdated
|
|
||
| See the comment in modules/server/src/main/ts/bedrock/core/Reporter.ts | ||
|
|
||
| # Contributing | ||
|
|
||
| See [CONTRIBUTING.md](CONTRIBUTING.md) | ||
|
|
||
| * `--clipboardPermission` to enable clipboard permission for Chromium. |
There was a problem hiding this comment.
This seems to be in the wrong file? 😂
There was a problem hiding this comment.
ha, too much caffeine is not good for me
| @@ -194,9 +196,9 @@ const setupShutdown = (driver: WebdriverIO.Browser, driverApi: DriverLoader.Driv | |||
| const driverShutdown = async (immediate?: boolean) => { | |||
| try { | |||
| if (immediate) { | |||
| driver.deleteSession(); | |||
| await driver.deleteSession(); | |||
There was a problem hiding this comment.
Some of this changed on my branch #145 so maybe we need to merge that and then redo this 🤔
| if (settings.headless) { | ||
| await driver.setWindowSize(1280, 1024); | ||
| } else { | ||
| await driver.maximizeWindow(); |
There was a problem hiding this comment.
This is still important, remote testing browsers regularly open at a very small size and cause tests to fail
| @@ -58,7 +58,8 @@ export const forAuto = (directories: Directories, argv: string[] = process.argv) | |||
| ClOptions.devicefarmRegion, | |||
| ClOptions.browserVersion, | |||
| ClOptions.platformName, | |||
| ClOptions.useSelenium | |||
| ClOptions.useSelenium, | |||
| ClOptions.clipboardPermission | |||
There was a problem hiding this comment.
This doesn't seem to be actually used anywhere? It always adds --enable-clipboard on chrome
There was a problem hiding this comment.
Yeah.. sorry should've been a draft pr, changing that now. 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket:
TINY-11431
Description of Changes:
Pre-checks:
Before merging: