Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT-3291: Support for TinyMCE Version 7 release #506

Merged
merged 26 commits into from
Mar 25, 2024
Merged

INT-3291: Support for TinyMCE Version 7 release #506

merged 26 commits into from
Mar 25, 2024

Conversation

danoaky-tiny
Copy link
Contributor

@danoaky-tiny danoaky-tiny commented Mar 20, 2024 •
edited
Loading

Jira ticket: INT-3291

Description of changes:

  • Upgraded dev dependencies
  • Added licenseKey prop that overrides the license_key prop in init.
  • Tests now test against version 7 as well.
  • Link to technical reference docs page is now included in the Editor component's JSDoc.
  • Improved cloudChannel type.
  • Changed default cloudChannel to '7'
  • Updated storybooks to use CSFv3 components, as well as enabling storybook arguments for some storybook objects
  • Storybooks now use react-vite bundler/builder instead of webpack
  • Added support for input and composition related native events, e.g. <Editor onInput="..." onCompositionEnd="..." />

spocke
spocke reviewed Mar 20, 2024
View reviewed changes
src/main/ts/components/Editor.tsx Show resolved Hide resolved
src/main/ts/components/Editor.tsx Outdated Show resolved Hide resolved
@danoaky-tiny danoaky-tiny marked this pull request as ready for review March 21, 2024 02:24
@danoaky-tiny danoaky-tiny requested a review from a team as a code owner March 21, 2024 02:24
@danoaky-tiny danoaky-tiny requested review from spocke, TheSpyder, ltrouton, ArvinJ-H, MitchC1999, tiny-ben-tran, shanmen-tiny and tiny-james and removed request for a team March 21, 2024 02:24
ltrouton
ltrouton approved these changes Mar 22, 2024
View reviewed changes
src/test/ts/browser/LoadTinyTest.ts Outdated Show resolved Hide resolved
@danoaky-tiny danoaky-tiny merged commit 185cf43 into main Mar 25, 2024
5 checks passed
@danoaky-tiny danoaky-tiny deleted the feature/INT-3291 branch March 25, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiny-james tiny-james tiny-james approved these changes

@ltrouton ltrouton ltrouton approved these changes

@spocke spocke Awaiting requested review from spocke spocke is a code owner automatically assigned from tinymce/tinymce-reviewers

@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder is a code owner automatically assigned from tinymce/tinymce-reviewers

@ArvinJ-H ArvinJ-H Awaiting requested review from ArvinJ-H

@MitchC1999 MitchC1999 Awaiting requested review from MitchC1999

@tiny-ben-tran tiny-ben-tran Awaiting requested review from tiny-ben-tran

@shanmen-tiny shanmen-tiny Awaiting requested review from shanmen-tiny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danoaky-tiny @spocke @tiny-james @ltrouton