Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tabIndex to be passed into editor #508

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

gjulivan
Copy link
Contributor

Currently, tabIndex can't be passed into the editor.
and this is not good for accessibility.

as mentioned on tinymce documentation: https://www.tiny.cloud/docs/tinymce/latest/editor-important-options/#taborder
tabIndex only able to be passed before init phase,
Thus, we need to pass tabIndex on component render.

This PR allows tabIndex to be passed as props on tinymce-react

@gjulivan gjulivan requested a review from a team as a code owner March 22, 2024 08:05
@gjulivan gjulivan requested review from spocke, TheSpyder and ltrouton and removed request for a team March 22, 2024 08:05
Copy link
Contributor

@danoaky-tiny danoaky-tiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me!

@EkimChau
Copy link
Contributor

EkimChau commented Apr 8, 2024

gjulivan

Hello gjulivan,

Thank you for your code contribution, in order for Tiny Inc to accept your code, we will need permission to use your code contribution, this can be done through the Tiny Contributor License Agreement (Tiny CLA). Please contact [email protected] to sign the Tiny CLA agreement.

@gjulivan
Copy link
Contributor Author

gjulivan commented Apr 8, 2024

gjulivan

Hello gjulivan,

Thank you for your code contribution, in order for Tiny Inc to accept your code, we will need permission to use your code contribution, this can be done through the Tiny Contributor License Agreement (Tiny CLA). Please contact [email protected] to sign the Tiny CLA agreement.

on it. thank you.

@EkimChau
Copy link
Contributor

gjulivan

Hello gjulivan,
Thank you for your code contribution, in order for Tiny Inc to accept your code, we will need permission to use your code contribution, this can be done through the Tiny Contributor License Agreement (Tiny CLA). Please contact [email protected] to sign the Tiny CLA agreement.

on it. thank you.

Thank you gjulivan, Tiny has received the signed CLA and we will accept your code contribution.

@danoaky-tiny danoaky-tiny merged commit c2679d0 into tinymce:main Apr 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants