This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
backport mem leak fix from upstream #252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkatraju
reviewed
Jul 21, 2022
go/vt/vtgate/vstream_manager.go
Outdated
| @@ -565,6 +567,11 @@ func (vs *vstream) sendAll(sgtid *binlogdatapb.ShardGtid, eventss [][]*binlogdat | |||
| } | |||
| } | |||
| vs.eventCh <- events | |||
There was a problem hiding this comment.
This line should be dropped since we now send this in the select below
There was a problem hiding this comment.
good catch, sorry about that.
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backport upstream fix vitessio#10571
Related Issue(s)
https://slack-pde.slack.com/archives/C01P84R7L02/p1657736244703949?thread_ts=1654116059.184499&cid=C01P84R7L02
Checklist
Deployment Notes