Implement individual students stickying #1723

JasonGrace2282 · 2024-09-25T02:56:03Z

Proposed changes

Allow stickying individual students to a scheduled 8th period.

Brief description of change

Closes #1719

Add a ManyToManyField to User called sticky_students.
There is also a new method called EighthScheduledActivity.is_user_stickied(user) which checks if an individual user is stickied, replacing the old get_sticky method.

You can edit the stickied students at /eighth/admin/scheduling/schedule?activity=<some_activity_pk>

alanzhu0

Great work - it looks like the core feature is working.

I don't know if you've noticed this, maybe it only occurs when you have a fairly large scheduling page (lots of instances), but the page load time is very slow. Run the dev autogenerate data scripts if you haven't. I'm getting 15s page load vs. 2s on production, and my dev is usually faster than prod. I assume it's due to populating all the fields with all those users. So we have to optimize this somehow. Maybe use JS and only populate the field when the user clicks on it?

And a few feature suggestions:

Can you distinguish between activity-sticky activities and user-sticky activities to the student? Right now they look the same to the student. Probably make the badge say "User Sticky" with an explanation tooltip instead of just "Sticky."
What do you think about sending an email to the user when they get user-sticked into an activity?

JasonGrace2282 · 2024-10-12T21:07:52Z

Maybe use JS and only populate the field when the user clicks on it?

I just pushed a commit that populates it as soon as the page has loaded. Could you check if that's fast enough for you?

As for sending an email, I'm not sure how much I would like that as a user - but I could also see it being really helpful for some people. As such, I'm -0 on the idea: if you really think it's useful/important, I can implement it.

alanzhu0

Ok, this is great, it loads very quickly now. But it doesn't seem to work anymore? When I put a user in and save it doesn't actually do anything, and the field gets wiped? Is it on my end?

alanzhu0 · 2024-10-13T18:06:55Z

Did you change the name to 'user sticky'? Also yes - email would be helpful if you can add that.

JasonGrace2282 · 2024-10-19T19:38:18Z

I haven't implemented email yet (if I get a chance later, I can do that), but everything else should be done, namely:

Fixing the bug with ajax
Changing the label to individual sticky

alanzhu0

Looking good and almost there

intranet/apps/eighth/views/admin/scheduling.py

coveralls · 2024-10-20T14:59:03Z

coverage: 79.118% (+0.02%) from 79.094%
when pulling 19ffbfd on JasonGrace2282:individual-sticky
into 129cfbc on tjcsl:dev.

alanzhu0 · 2024-10-20T15:59:22Z

intranet/apps/eighth/models.py

+            signup = EighthSignup.objects.filter(user=user, scheduled_activity__block=self.block).first()
+            if signup is not None:
+                signup.remove_signup(user, force=True)
+            EighthSignup.objects.create_signup(user, scheduled_activity=self)


Still not the right way to do it, I think...again look at the signup view. I took a look myself and I believe you need to use EighthScheduledActivity.add_user

intranet/apps/eighth/models.py

alanzhu0 · 2024-10-20T16:01:57Z

intranet/templates/eighth/emails/students_stickied.html

+      You have been stickied into {{ activity.activity.name }} on {{ activity.date }} ({{ activity.block_letter }}).
+
+      If there has been a mistake with this change, please contact the 8th period office.
+      Have a nice day!


I dont think you need this lol

It never hurts to tell people to have a nice day :)

alanzhu0 · 2024-10-20T16:04:50Z

intranet/apps/eighth/models.py

@@ -1097,10 +1115,50 @@ def notify_waitlist(self, waitlists: Iterable["EighthWaitlist"]):
                [waitlist.user.primary_email_address],
            )

+    def set_sticky_students(self, users: "Sequence[AbstractBaseUser]") -> None:


alanzhu0 · 2024-10-20T16:05:02Z

intranet/apps/eighth/models.py

+        # note: this will send separate emails to each student for each activity they are stickied in
+        new_stickied_students = (user for user in users if user not in old_sticky_students)
+        unstickied_students = (user for user in old_sticky_students if user not in users)
+        email_send_task.delay(


i think this works

Closes tjcsl#1719

JasonGrace2282 force-pushed the individual-sticky branch 4 times, most recently from 8c235c7 to df67d6c Compare September 25, 2024 20:42

JasonGrace2282 marked this pull request as ready for review September 25, 2024 20:43

JasonGrace2282 requested a review from a team as a code owner September 25, 2024 20:43

JasonGrace2282 force-pushed the individual-sticky branch 5 times, most recently from 55b02c9 to 9bad520 Compare September 26, 2024 03:03

alanzhu0 requested changes Oct 4, 2024

View reviewed changes

JasonGrace2282 force-pushed the individual-sticky branch from 9bad520 to 4d1140a Compare October 12, 2024 21:05

JasonGrace2282 force-pushed the individual-sticky branch 2 times, most recently from 4ca8bd3 to 67d71e7 Compare October 13, 2024 13:37

alanzhu0 requested changes Oct 13, 2024

View reviewed changes

JasonGrace2282 force-pushed the individual-sticky branch 3 times, most recently from 30fe65a to 781dc23 Compare October 19, 2024 19:28

JasonGrace2282 requested a review from alanzhu0 October 19, 2024 19:37

alanzhu0 requested changes Oct 19, 2024

View reviewed changes

intranet/apps/eighth/views/admin/scheduling.py Outdated Show resolved Hide resolved

JasonGrace2282 force-pushed the individual-sticky branch from 781dc23 to d726662 Compare October 20, 2024 14:52

JasonGrace2282 force-pushed the individual-sticky branch from d726662 to efe5a47 Compare October 20, 2024 15:19

alanzhu0 requested changes Oct 20, 2024

View reviewed changes

JasonGrace2282 force-pushed the individual-sticky branch from efe5a47 to 9d33d97 Compare October 20, 2024 16:19

feat: implement individual students stickying

19ffbfd

Closes tjcsl#1719

JasonGrace2282 force-pushed the individual-sticky branch from 9d33d97 to 19ffbfd Compare October 23, 2024 16:18

alanzhu0 approved these changes Oct 23, 2024

View reviewed changes

alanzhu0 merged commit 49de27c into tjcsl:dev Oct 23, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement individual students stickying #1723

Implement individual students stickying #1723

JasonGrace2282 commented Sep 25, 2024 •

edited

Loading

alanzhu0 left a comment

JasonGrace2282 commented Oct 12, 2024

alanzhu0 left a comment

alanzhu0 commented Oct 13, 2024

JasonGrace2282 commented Oct 19, 2024

alanzhu0 left a comment

coveralls commented Oct 20, 2024 •

edited

Loading

alanzhu0 Oct 20, 2024

alanzhu0 Oct 20, 2024

JasonGrace2282 Oct 20, 2024

alanzhu0 Oct 20, 2024

alanzhu0 Oct 20, 2024

Implement individual students stickying #1723

Implement individual students stickying #1723

Conversation

JasonGrace2282 commented Sep 25, 2024 • edited Loading

Proposed changes

Brief description of change

alanzhu0 left a comment

Choose a reason for hiding this comment

JasonGrace2282 commented Oct 12, 2024

alanzhu0 left a comment

Choose a reason for hiding this comment

alanzhu0 commented Oct 13, 2024

JasonGrace2282 commented Oct 19, 2024

alanzhu0 left a comment

Choose a reason for hiding this comment

coveralls commented Oct 20, 2024 • edited Loading

alanzhu0 Oct 20, 2024

Choose a reason for hiding this comment

alanzhu0 Oct 20, 2024

Choose a reason for hiding this comment

JasonGrace2282 Oct 20, 2024

Choose a reason for hiding this comment

alanzhu0 Oct 20, 2024

Choose a reason for hiding this comment

alanzhu0 Oct 20, 2024

Choose a reason for hiding this comment

JasonGrace2282 commented Sep 25, 2024 •

edited

Loading

coveralls commented Oct 20, 2024 •

edited

Loading