Skip to content

Commit

Permalink
CRAN submission 3, removed csv
Browse files Browse the repository at this point in the history
  • Loading branch information
tjebo committed Jun 25, 2020
1 parent e4c7d1d commit 15d69e7
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 61 deletions.
4 changes: 2 additions & 2 deletions CRAN-RELEASE
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
This package was submitted to CRAN on 2020-06-12.
Once it is accepted, delete this file and tag the release (commit b6777e6ae1).
This package was submitted to CRAN on 2020-06-18.
Once it is accepted, delete this file and tag the release (commit e4c7d1deae).
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Authors@R: c(
Description: A tool to facilitate common tasks in ophthalmic research:
Conversion between different visual acuity notations (Snellen, logMAR
and ETDRS), counting of patients, recode right and left eyes and reshape
eye side specific variables between wide and long format. The eye
eye side specific variables between wide and long format. The 'eye'
package also contains a real life data set of people with intravitreal
injections with anti-vascular endothelial growth factor (anti-VEGF),
made available by Fasler et al. (2019) <doi:10.1136/bmjopen-2018-027441>.
Expand Down
1 change: 0 additions & 1 deletion NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export(age)
export(blink)
export(clean_va)
export(convertVA)
export(csv)
export(eyes)
export(eyestr)
export(hyperop)
Expand Down
1 change: 0 additions & 1 deletion R/eye.R
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#' *eye* contains a real life data set [`eye::amd`]
#' @section Beyond ophthalmology:
#' - [`age`]: Calculate age
#' - [`csv`]: Conveniently save a data frame to csv
#' @docType package
#' @keywords internal
#' @seealso
Expand Down
21 changes: 0 additions & 21 deletions R/tools.R
Original file line number Diff line number Diff line change
Expand Up @@ -39,27 +39,6 @@ age <- function(from_date,
}
}

#' csv
#' @description wrapper around write.csv with default 'row.names = FALSE'.
#' Will use the name of the data frame for the generated .csv file.
#' @name csv
#' @param x data frame
#' @param name Filename (Default: Name of dataframe). If provided,
#' character string (.csv extension added automatically)
#' @family convenience functions
#' @return No return value, called for side effects (saving file)
#' @examples
#' \dontrun{
#' csv(amd)
#' }
#' @export
csv <- function(x, name = NULL) {
if(is.null(name)){
name <- deparse(substitute(x))
}
file = paste0(name, '.csv')
utils::write.csv(x, file, row.names = F)
}

#' Capitalize words
#' @name tocapital
Expand Down
6 changes: 6 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## Resubmission #3
CRAN-submission comment fixes
1. Decision to remove `csv()`, which created most issues. It was just a tiny convenience wrapper and did not exactly fit into the main scope of the package, and it was not required by any other function, so it could be removed without any further change
of the package structure.
2. Added single quotes to 'eye' in description field of Description.

## Resubmission #2

### This second resubmission was re-checked on all test environments detailed under the first submission below.
Expand Down
3 changes: 0 additions & 3 deletions man/age.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 0 additions & 31 deletions man/csv.Rd

This file was deleted.

1 change: 0 additions & 1 deletion man/eye.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 15d69e7

Please sign in to comment.