Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve config setup (#9) #9

Merged
merged 1 commit into from
Sep 23, 2024
Merged

feat: improve config setup (#9) #9

merged 1 commit into from
Sep 23, 2024

Conversation

tkrop
Copy link
Owner

@tkrop tkrop commented Sep 23, 2024

This pull request improves the config setup to require a parameter less during initial setup and changes the not-as-expected working SetupLogger function.

Both changes are actually braking changes.

@tkrop tkrop added the enhancement New feature or request label Sep 23, 2024
@tkrop tkrop self-assigned this Sep 23, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9eead42) 338 338 100.00%
Head commit (a2d1e14) 336 (-2) 336 (-2) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#9) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@tkrop tkrop merged commit 3e23247 into main Sep 23, 2024
6 of 7 checks passed
@tkrop tkrop deleted the config-setup branch September 23, 2024 06:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10988571153

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10984663485: 0.0%
Covered Lines: 336
Relevant Lines: 336

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants