Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add Camera.camera_type and other refactors #91

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

tlambert03
Copy link
Owner

closes #90

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 82.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 84.79%. Comparing base (dc73755) to head (abb5dde).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/microsim/schema/detectors/_camera.py 80.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   84.82%   84.79%   -0.04%     
==========================================
  Files          47       47              
  Lines        3144     3156      +12     
==========================================
+ Hits         2667     2676       +9     
- Misses        477      480       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 729dcfe into main Jan 7, 2025
17 of 18 checks passed
@tlambert03 tlambert03 deleted the camera-update branch January 7, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detectors do not have pydantic discriminator field
1 participant