Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new JLine dependencies #863

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Add new JLine dependencies #863

merged 3 commits into from
Jan 15, 2024

Conversation

pera
Copy link
Contributor

@pera pera commented Jan 15, 2024

This PR relates to #862

In JLine 3.25.0 there are two extra dependencies:

  • jline-builtins
  • jline-console

Signature/hashes of the included artifacts:
https://repo1.maven.org/maven2/org/jline/jline-builtins/3.25.0/
https://repo1.maven.org/maven2/org/jline/jline-console/3.25.0/

I am opening this as a draft because there are currently 4 test cases that for some reason are not passing on my machine (not sure if my dev environment is setup correctly though):

-------------------------------------------------------------------------------
Test set: org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest
-------------------------------------------------------------------------------
Tests run: 8, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 0.004 s <<< FAILURE! - in org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest
testXA(org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest)  Time elapsed: 0.002 s  <<< FAILURE!
java.lang.AssertionError: expected:<2> but was:<1>
        at org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest.testX(TLCErrorTest.java:191)
        at org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest.testXA(TLCErrorTest.java:136)

testXB(org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest)  Time elapsed: 0 s  <<< FAILURE!
java.lang.AssertionError: expected:<2> but was:<1>
        at org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest.testX(TLCErrorTest.java:191)
        at org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest.testXB(TLCErrorTest.java:140)

testXC(org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest)  Time elapsed: 0 s  <<< FAILURE!
java.lang.AssertionError: expected:<2> but was:<1>
        at org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest.testX(TLCErrorTest.java:191)
        at org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest.testXC(TLCErrorTest.java:144)

testXD(org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest)  Time elapsed: 0 s  <<< FAILURE!
java.lang.AssertionError: expected:<2> but was:<1>
        at org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest.testX(TLCErrorTest.java:191)
        at org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest.testXD(TLCErrorTest.java:148)

testA(org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest)  Time elapsed: 0 s
testB(org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest)  Time elapsed: 0.001 s
testC(org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest)  Time elapsed: 0 s
testD(org.lamport.tla.toolbox.tool.tlc.output.data.TLCErrorTest)  Time elapsed: 0 s

These tests are in:
tlaplus/toolbox/org.lamport.tla.toolbox.tool.tlc.ui.test/src/org/lamport/tla/toolbox/tool/tlc/output/data/TLCErrorTest.java

@lemmy any ideas?

In JLine 3.25.0 there are two extra dependencies:
* jline-builtins
* jline-console

Signed-off-by: Brian Gomes Bascoy <[email protected]>
@lemmy
Copy link
Member

lemmy commented Jan 15, 2024

TLCErrorTest seems unrelated.

@lemmy
Copy link
Member

lemmy commented Jan 15, 2024

Consider adding the Toolbox build to the pr.yml workflow to check if the test failures also occur on the build machine.

    - name: Build with Maven (Linux)
      run: ${{ matrix.MVN_COMMAND }} -Dtycho.disableP2Mirrors=true -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -fae -B verify --file pom.xml

@pera
Copy link
Contributor Author

pera commented Jan 15, 2024

Yeah it looks unrelated: I get the same failures when running the tests in the commit before mine (63e2a4c)

Signed-off-by: Brian Gomes Bascoy <[email protected]>
@lemmy
Copy link
Member

lemmy commented Jan 15, 2024

You also need to include the definition of ${{ matrix.MVN_COMMAND }} at the top of main.yml.

Signed-off-by: Brian Gomes Bascoy <[email protected]>
@pera
Copy link
Contributor Author

pera commented Jan 15, 2024

Thanks, missed that variable

@pera pera marked this pull request as ready for review January 15, 2024 21:07
@lemmy lemmy merged commit 08adf79 into tlaplus:master Jan 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants