-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH601: Enable snupkg symbol packages #628
Conversation
@tmenier PTAL. Re deterministic builds, I'm assuming the NuGet packages that are published are built on AppVeyor. |
Downloading AppVeyor 39079294 artifacts: |
Given that it's been a full year since you opened this (yikes...sorry!) can I assume this is still necessary in .NET 6 and still the most modern/recommended way of doing this? Also is it safe to assume it won't adversely affect anyone's dev experience? I'm about to start on 4.0 and wondering if this should go in the final 3.x maintenance release or the first 4.0 prerelease. As I mentioned in #601, this isn't my area of expertise so I'm going to trust your judgement here. Thanks! :) |
Yes, I think the issue I mention in #601 (comment) is only going to be addressed in the dotnet 7 sdk. That and publishing a separate If you want to publish a maintenance release with this change then I'll make sure to confirm that I can still step debug with it. |
I was hoping I could get this published quickly so you could test it but it looks like the snupkg needs to be uploaded separately and I have no idea where to do that. I'll let you know when I figure that out. |
How are you publishing now? IIRC, it should just work given the changes I made... |
I upload the nupkg to nuget.org. |
Using what command? That command should handle uploading the |
Using the web site. I publish the packages manually and I don't see a place to upload a symbols package. |
Doh...I stand corrected - you can totally do it from the web UI. Same upload box even. Don't know how I missed that! I'm getting this (pre)released now. I know my processes could use improving and I'd love to move off of AppVeyor and on to GH Actions, then automate releases. But like with so many things I just haven't had the time. |
Following up from #601.