Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change colours of graphs for the colour blind #78

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kiwamacey
Copy link

Hope the colours aren't too gaudy for everyone. Changed in Graph.scala and main.js.***

@tobyweston
Copy link
Owner

Thanks for the PR. It'll be great to merge, I just have to find some time to do it! When I do, I'll update the release notes so we can track the features going into the next release.

Remember, after it's merged, it wont appear in the apt-get repo until we do a formal release.

@tobyweston
Copy link
Owner

Just spotted a few problems, the .js file is generated from https://github.com/tobyweston/temperature-machine-ui and copied over. I'll most likely do that work on your behalf and reproduce it here (otherwise, it'll get lost on the next UI build). Don't worry, the colour choices are the main thing and I'll be sure to get them in. Thanks again

@kiwamacey
Copy link
Author

Just checking, did this get included in the new release?

@tobyweston
Copy link
Owner

Sorry, no. The release was just to patch the oracle issue. Will try and feed this and a bunch of other stuff in v2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants