Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support string target #1

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Support string target #1

merged 2 commits into from
Feb 5, 2025

Conversation

MichalChromcak
Copy link
Collaborator

This MR aims to support also string targets.

More specifically, it includes:

  • removal of the dtype conversion for the target
  • tests towards int and string targets

tocab
tocab reviewed Feb 4, 2025
View reviewed changes
Copy link
Owner

@tocab tocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing :) It looks good, I would only remove the commented code.

efficient_trees/tree.py Outdated Show resolved Hide resolved
@MichalChromcak @tocab
Update efficient_trees/tree.py
84e3c1b 
Co-authored-by: Tobias Cabanski <[email protected]>
@MichalChromcak MichalChromcak requested a review from tocab February 5, 2025 07:54
@tocab tocab merged commit e48cc19 into tocab:main Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tocab tocab Awaiting requested review from tocab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichalChromcak @tocab