Fix build on FreeBSD #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2018 11:07
This function was originally added because it was missing from FreeBSD libusb. FreeBSD has subsequently _gained_ that function, in 2012. See this commit: freebsd/freebsd-src@2463f20
blink1-tool relies upon GNU Make and fails on BSD Make. This change forces the use of gmake where it's explicitly available.
This was referenced Nov 15, 2018
Closed
The const declaration was removed from FreeBSD iconv in 2015: https://svnweb.freebsd.org/ports?view=revision&revision=384038
Closed
added 4 commits
November 15, 2018 14:36
Fixes an odd error when nesting Makefiles using GNU Make on FreeBSD, and cleaning (but _not_ compiling).
This should prevent more compiler warnings from sneaking back in.
On some systems, for example FreeBSD, bash lives elsewhere by default, for example in /usr/local/bin.
|
This PR convolves a lot of different issues. I think I addressed the blink1-tool-specific ones. The hidapi ones should be submitted to the hidapi repo. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several issues w/ blink1-tool on FreeBSD:
make cleanfails #17 (by using$(MAKE)everywhere).Also makes a few sundry improvements:
bashlived in/bin.