Skip to content
This repository was archived by the owner on Oct 7, 2021. It is now read-only.

Added clarification about importance of DefaultInterface configuration #139

Merged
merged 3 commits into from
Apr 7, 2017

Conversation

Mierdin
Copy link
Member

@Mierdin Mierdin commented Mar 20, 2017

Just adding some clarification about DefaultInterface since this code was recently changed, and several issues have illuminated shortcomings in the current docs.

Closes #113

@Mierdin Mierdin requested a review from LindsayHill March 20, 2017 06:27
@Mierdin Mierdin added the RFR label Mar 20, 2017
Copy link

@LindsayHill LindsayHill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor style things, but is generally fine

@@ -4,12 +4,21 @@ Configuring ToDD
ToDD uses configuration files (typically found in ``/etc/todd``) to control it's behavior. The server and the agent use their own individual config files, and sample files are shown below.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/it's/its/ for this usage

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also break second sentence in two. Maybe:

The server and the agent each use their own individual config files. Samples are shown below.


.. WARNING::

Pay particular note to he LocalResources section of the configuration. The DefaultInterface option is required (or in lieu thereof, the IPAddrOverride option) so that the server will know what IP address to serve assets from to the agents. The server will not successfully start if an address is not determined.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/to he/to the/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might consider formatting marks around "LocalResources", "DefaultInterface", "IPAddrOverride" - e.g. put `` around each.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would write "The server will not successfully start if an address is not determined" as
"The server will not start if it cannot determine its IP address." Minor style thing though, so it's not important.


Pay particular note to he LocalResources section of the configuration. The DefaultInterface option is required (or in lieu thereof, the IPAddrOverride option) so that the server will know what IP address to serve assets from to the agents. The server will not successfully start if an address is not determined.

If this is configured, but incorrectly, agents may not retrieve the required asset files and will therefore fail to register with the server.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could make it more simpler with "If this is configured incorrectly, agents will be unable to retrieve the required asset files, and will fail to register with the server."

@Mierdin
Copy link
Member Author

Mierdin commented Apr 7, 2017

@LindsayHill All great comments - thanks!

@Mierdin Mierdin merged commit 85fef62 into master Apr 7, 2017
@Mierdin Mierdin deleted the docs/defaultinterface-clarification branch April 7, 2017 04:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants