Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer model #123

Merged
merged 4 commits into from
Jan 18, 2021
Merged

Viewer model #123

merged 4 commits into from
Jan 18, 2021

Conversation

rikkegammelmark
Copy link
Contributor

No description provided.

jstroem
jstroem approved these changes Jan 15, 2021
View reviewed changes
src/generator/sdk.ts
};
}

function moduleFromModule(toitModule: ToitModule, path: string[]): Module {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe convertModule

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current name is more consistent with the rest of the functions.

@rikkegammelmark rikkegammelmark merged commit bcc0c0a into master Jan 18, 2021
@rikkegammelmark rikkegammelmark deleted the rikke-model branch January 18, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstroem jstroem jstroem approved these changes

@jacobqvist jacobqvist jacobqvist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rikkegammelmark @jstroem @jacobqvist