Add try_write to TcpStream #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Pike <[email protected]>
mcches
reviewed
Jul 12, 2024
src/net/tcp/stream.rs
Outdated
| /// # Return | ||
| /// | ||
| /// If data is successfully written, `Ok(n)` is returned, where `n` is the | ||
| /// number of bytes written. If the stream has been shut down |
There was a problem hiding this comment.
nit: I'd just copy the doc verbatim. In future changes this will do what the tokio flavor does and then we don't need to update the doc.
There was a problem hiding this comment.
Missed this nit. You're probably right, although I see some (small) benefit in the doc representing the current state
Signed-off-by: Brandon Pike <[email protected]>
Signed-off-by: Brandon Pike <[email protected]>
Signed-off-by: Brandon Pike <[email protected]>
mcches
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
TcpStream::try_write()andWriteHalf::try_write().These allow for a result-based synchronous write attempt.