Update to rand 0.9 #215
Open
Update to rand 0.9 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcches
reviewed
Jan 30, 2025
| @@ -22,8 +22,8 @@ members = ["examples/*"] | |||
| [dependencies] | |||
| bytes = "1.4" | |||
| indexmap = "2" | |||
| rand = { version = "0.8.5", features = ["small_rng"] } | |||
| rand_distr = "0.4.3" | |||
| rand = { version = "0.9", features = ["small_rng"] } | |||
There was a problem hiding this comment.
I'm a little fuzzy on cargo resolver. Will this break consumers who also declare a dependency on 0.8?
There was a problem hiding this comment.
This seems a breaking change as rand updated rand_core and rand_core::RngCore is exposed at the Builder::build_with_rng.
https://docs.rs/turmoil/0.6.5/turmoil/struct.Builder.html#method.build_with_rng
There was a problem hiding this comment.
Let's stash this one and we can bundle it when we go to 0.7?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to rand 0.9.