fix: custom extractor warnings optional (#114)

tolgee · Sep 23, 2024 · ffa66da · ffa66da
1 parent 2e30591
commit ffa66da
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/src/commands/extract/check.ts b/src/commands/extract/check.ts
@@ -23,7 +23,7 @@ const lintHandler = (config: Schema) =>
     let warningCount = 0;
     let filesCount = 0;
     for (const [file, { warnings }] of extracted) {
-      if (warnings.length) {
+      if (warnings?.length) {
         warningCount += warnings.length;
         filesCount++;
 

diff --git a/src/commands/extract/print.ts b/src/commands/extract/print.ts
@@ -41,7 +41,7 @@ const printHandler = (config: Schema) =>
         }
       }
 
-      if (warnings.length) {
+      if (warnings?.length) {
         warningCount += warnings.length;
         console.log(
           '%d warning%s %s emitted during extraction:',
@@ -60,7 +60,7 @@ const printHandler = (config: Schema) =>
         }
       }
 
-      if (keys.length || warnings.length) {
+      if (keys.length || warnings?.length) {
         console.log();
       }
     }

diff --git a/src/extractor/index.ts b/src/extractor/index.ts
@@ -28,9 +28,6 @@ export type Extractor = (
   options: ExtractOptions
 ) => ExtractionResult;
 
-export type ExtractionResult = { keys: ExtractedKey[]; warnings: Warning[] };
+export type ExtractionResult = { keys: ExtractedKey[]; warnings?: Warning[] };
 
-export type ExtractionResults = Map<
-  string,
-  { keys: ExtractedKey[]; warnings: Warning[] }
->;
+export type ExtractionResults = Map<string, ExtractionResult>;
diff --git a/src/extractor/warnings.ts b/src/extractor/warnings.ts
@@ -64,7 +64,7 @@ export function dumpWarnings(extractionResult: ExtractionResults) {
   let warningCount = 0;
 
   for (const [file, { warnings }] of extractionResult.entries()) {
-    if (warnings.length) {
+    if (warnings?.length) {
       if (!warningCount) {
         console.error('Warnings were emitted during extraction.');
       }