Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: maintenance, CI and misc improvements #106

Merged
merged 9 commits into from
Sep 12, 2024

Conversation

cyyynthia
Copy link
Collaborator

@cyyynthia cyyynthia commented Aug 9, 2024

  • Upgraded all dependencies to latest versions, fixing all possible npm audit complaints of vulnerable versions
  • Ditched form-data; Node 18+ has support for FormData natively
  • Migrated to ESLint v9 config format
  • Made scripts TypeScript instead of plain js
  • Simplified TS configuration to use presets from tsbases
  • Moved tests out of src - TS config tweaks no longer mess with the output
  • Added #cli and #tests imports specifiers to cleanup some ../../../../ hell
  • Updated TM grammars; they are also now minified to take less space
  • Upgraded CI action versions to v4
  • Made unit tests and e2e tests run on Linux, Windows, and MacOS on Node 18, 20 and 22
  • And some other misc tweaks 😅

Additionally, the (currently-broken) code reliant on ts-node has been commented out; a more stable solution appears to be based on what other packages do to compile the ts file to a temporary .js file and use this js file instead.

@cyyynthia cyyynthia added the enhancement New feature or request label Aug 9, 2024
@cyyynthia cyyynthia requested a review from stepan662 August 9, 2024 10:45
package.json Show resolved Hide resolved
src/client/ImportClient.ts Show resolved Hide resolved
test/e2e/formats.test.ts Outdated Show resolved Hide resolved
@cyyynthia
Copy link
Collaborator Author

I was quite eager to get the CI up and running on Windows and Mac but it seems that GitHub Actions support for it is... not great, to say the least. :(

The complete lack of proper Docker support makes it very difficult to get a test instance of Tolgee running... :/

  • On macOS, it requires some workarounds that don't seem to always behave nicely, and don't work on M1 and M2 powered macs
  • On Windows, their setup predates WSL2 and as such while Docker is installed, it doesn't run in Linux mode via WSL2 - so it can't run the Tolgee image

@cyyynthia cyyynthia requested a review from stepan662 August 9, 2024 12:59
@stepan662 stepan662 merged commit 2e30591 into main Sep 12, 2024
14 checks passed
@stepan662 stepan662 deleted the cynthia/chore-maintenance branch September 12, 2024 11:22
Copy link

🎉 This issue has been resolved in version 2.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants