feat: TS extractors are back, take 2 #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepan662
reviewed
Dec 4, 2024
There was a problem hiding this comment.
You are reverting fixtures from this PR #134
There was a problem hiding this comment.
Or is it not necessary with tinygloby?
There was a problem hiding this comment.
Tinyglobby doesn't have a windows-specific "quick and dirty" fix; it's handled by replacing back slashes with forward slashes in paths before constructing globs instead
stepan662
approved these changes
Dec 4, 2024
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try #129 again :)
I manually ran the test suite on my Windows laptop, all green. I wish we could run e2e tests on GHA Windows/macOS, would've saved so many headaches, oh well...
Pinned openapi-fetch's version because they seem to push a broken package every now and then, so version ranges just explode for no reason (:
Didn't upgrade to TypeScript 5.7 due to a regression with JSON modules resolution (enforces uses of import attributes despite not existing in Node 18)