-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new extractor #88
Conversation
- improved performance - parsing all files not just those importing from `@tolgee/*` - default namespace option - option to not be so strict with namespace detectability
91a0a90
to
889ffb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's some impressive changes! ❤️
I haven't look very deeply into the state machines logic; tests should've caught any regression while rewriting the extraction logic. Looks neat though!
- xstate can be removed from the dependencies
- (unrelated to PR) undici and requester.ts code can be removed since it has been replaced with openapi-fetch // hacking.md might need to be updated as well
- I added some
closes
comment, but additional issues may be closed by this PR: Can't handle nested translations #84 Feature Request: Additional Support for some VueJs Patterns #66
Thanks for your great work Stephan! I tried the recent version of the cli with the new extractor, and it fails on "Dynamic options" for this line:
Works OK after removing the |
Another issue, seems like the |
@OrenChapo thanks for reporting, should be fixed in this PR: |
Closes #63
Closes #87