Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow jsx values in argument notation when using format-icu #3251

Conversation

kalimantos
Copy link

@stepan662
Copy link
Collaborator

Hey, thank you for your effort. I get that it solves your problem, but this is not good for maintenance. Would it be possible for you to release this as e.g. separate npm package? You are not changing anything in the tolgee core, so it should be possible to release this as a plugin in a package.

@kalimantos
Copy link
Author

Thank you @stepan662 for the response, you mean the entire format-icu as a separate tolgee plugin or just the edited intl-messageformat?

@stepan662
Copy link
Collaborator

I mean just making an alternative package e.g. tolgee-format-icu-jsx-param (or some better name) which will be used the same way as format-icu, but with the support for the interpolation.

@kalimantos
Copy link
Author

ok thank you, I'll do it as soon as I can

@kalimantos kalimantos closed this Sep 27, 2023
@stepan662
Copy link
Collaborator

Cool, thank you :)

@JanCizmar
Copy link
Contributor

Anyway, thanks for this contribution, when you're done, we can add mention of your package to the docs.

@kalimantos
Copy link
Author

Awesome thank you, i'll notice you when is ready

@kalimantos
Copy link
Author

Finally, here it is https://github.com/Artshell-company/tolgee-format-icu-jsx-param

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants