fix: Proper unsubscribing from websockets (#2838)

tolgee · Jan 14, 2025 · 55ee489 · 55ee489
1 parent 45ff869
commit 55ee489
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/webapp/src/websocket-client/WebsocketClient.ts b/webapp/src/websocket-client/WebsocketClient.ts
@@ -33,7 +33,7 @@ export const WebsocketClient = (options: TranslationsClientOptions) => {
 
   let _client: CompatClient | undefined;
   let connected = false;
-  const subscriptions: Subscription<any>[] = [];
+  let subscriptions: Subscription<any>[] = [];
 
   const resubscribe = () => {
     if (_client) {
@@ -79,6 +79,7 @@ export const WebsocketClient = (options: TranslationsClientOptions) => {
       subscriptions.forEach((s) => {
         s.unsubscribe = undefined;
         s.id = undefined;
+        removeSubscription(s);
       });
       options.onConnectionClose?.();
     };
@@ -120,6 +121,7 @@ export const WebsocketClient = (options: TranslationsClientOptions) => {
 
     return () => {
       subscription.unsubscribe?.();
+      removeSubscription(subscription);
     };
   }
 
@@ -129,6 +131,10 @@ export const WebsocketClient = (options: TranslationsClientOptions) => {
     }
   }
 
+  function removeSubscription(subscription: Subscription<any>) {
+    subscriptions = subscriptions.filter((it) => it !== subscription);
+  }
+
   return Object.freeze({ subscribe, disconnect });
 };