fix: Batch operation spams slack #2781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 30 days with no activity. |
JanCizmar
force-pushed
the
jancizmar/fix-batch-slack-spamming
branch
from
85c4311 to
cc07cda
Compare
…til the batch operation completes and merges the activity
JanCizmar
force-pushed
the
jancizmar/fix-batch-slack-spamming
branch
from
ec2c5e5 to
69e56de
Compare
JanCizmar
requested review from
Anty0 and
stepan662
and removed request for
Anty0
fprochazka
reviewed
Feb 17, 2025
| // Execute the message updates only if there are not too many messages to update | ||
| // Otherwise Slack will complain about too many requests | ||
| if (messageUpdateActions.size > MAX_MESSAGES_TO_UPDATE) { | ||
| logger.debug("Too many messages to update, skipping") |
There was a problem hiding this comment.
this does not terminate any logic, it's just logging
|
FYI #2917 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.