feat: Notifications MVP #2813
Merged
feat: Notifications MVP #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanCizmar
requested changes
Jan 7, 2025
backend/data/src/main/kotlin/io/tolgee/service/NotificationService.kt
Outdated
Show resolved
Hide resolved
ee/backend/app/src/main/kotlin/io/tolgee/ee/api/v2/controllers/NotificationsController.kt
Outdated
Show resolved
Hide resolved
ee/backend/app/src/main/kotlin/io/tolgee/ee/api/v2/controllers/NotificationsController.kt
Outdated
Show resolved
Hide resolved
ee/backend/app/src/main/kotlin/io/tolgee/ee/service/TaskAssigneeUpdatedNotificationListener.kt
Outdated
Show resolved
Hide resolved
backend/data/src/main/kotlin/io/tolgee/service/NotificationService.kt
Outdated
Show resolved
Hide resolved
backend/data/src/main/kotlin/io/tolgee/repository/NotificationRepository.kt
Outdated
Show resolved
Hide resolved
I would released it in this scope after a bit of additional polish and then added the new features in separate PRs. According to continuous delivery of value. The problem with the need to review everything again would therefore be bypassed. I am open for discussion.
|
StaNov
force-pushed
the
stanov/notifications
branch
6 times, most recently
from
ffed0c7 to
6ffaad5
Compare
StaNov
force-pushed
the
stanov/notifications
branch
6 times, most recently
from
1529eeb to
0263d49
Compare
JanCizmar
requested changes
Jan 14, 2025
backend/data/src/main/kotlin/io/tolgee/service/notification/NotificationService.kt
Outdated
Show resolved
Hide resolved
backend/data/src/main/kotlin/io/tolgee/repository/NotificationRepository.kt
Outdated
Show resolved
Hide resolved
ee/backend/app/src/main/kotlin/io/tolgee/ee/component/TaskNotificationEnhancer.kt
Show resolved
Hide resolved
…otificationService
StaNov
force-pushed
the
stanov/notifications
branch
from
0263d49 to
9a0458c
Compare
JanCizmar
approved these changes
Jan 14, 2025
StaNov
force-pushed
the
stanov/notifications
branch
from
9e937bf to
adb5b20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements #2577.