fundsp #33
Open
fundsp #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Ok(Self { _stream: stream, custom_organ_hz, _frontend_net: frontend_net }) | ||
| } | ||
|
|
||
| fn build_dsp_graph(custom_organ_hz: &Shared<f64>) -> (Net64, Net64Backend) { |
There was a problem hiding this comment.
Maybe it's just lack of experience with sound synthesis, but I'm a bit lost as to what this function does (especially since it uses that strange DSL reusing the shift operators and whatnot) so a couple comments would go a long way here.
PabloMansanet
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still playing around with this, but I have a basic proof-of-concept for generating sound and modifying it via atomic variables.
Next step will probably be to re-add the sound samples we had previously with the jukebox.
For playing multiple sound effects (in a potentially spammy manner), we could probably draw some inspiration from how video games do it: https://www.reddit.com/r/gamedev/comments/dq4k3q/how_do_you_handle_a_bunch_of_sound_effects/f60hlly/