Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler error of the cli example #17

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Fix compiler error of the cli example #17

merged 1 commit into from
Feb 25, 2024

Conversation

skywhale
Copy link
Member

No description provided.

@skywhale skywhale requested a review from bschwind February 25, 2024 09:54
@bschwind
Copy link
Member

Thanks, @skywhale! This motivated me to fix the CI for this repo so further PRs can be better verified. Could you rebase this on main to pick up the CI checks?

@skywhale
Copy link
Member Author

@bschwind thank you :) rebased!

@bschwind
Copy link
Member

Oh! And I should update CI to use --features="serde_support" or else it wouldn't catch the very issue you're fixing. I'll add that next.

bschwind
bschwind approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bschwind bschwind merged commit bd11f21 into main Feb 25, 2024
2 checks passed
@bschwind bschwind deleted the fix-cli-build branch February 25, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschwind bschwind bschwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skywhale @bschwind