Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated automount-usb.sh to look for a particular parition label "NAS" #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bmahabirbu
Copy link

@bmahabirbu bmahabirbu commented Mar 9, 2024

This aims to fix the issue where the udev rule spits out a random partition in sda that might not contribute to the partition that has the games.

For example lets say we have a USB drive that has sda
sda1 - 30m
sda2 - 200gb

since the udev rule will detect sda being added it will always forward the first partition and update the samba share config with sda1 instead of sda2

at first, the idea was to sort the partitions by size but it was finicky. In the end I settled on looking for a label as it was more straightforward

@georgewoodall82
Copy link
Contributor

georgewoodall82 commented Mar 9, 2024

I see you undone all changes to automount-usb.sh made in the last commit. was this intentional?

@bmahabirbu
Copy link
Author

It was not my mistake, I ended up replacing the contents of automount-usb.sh as my debugging environment was different than the repo I cloned.

@bmahabirbu
Copy link
Author

I updated my forked repo so it only shows the changed I added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants