-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github/workflows/centos: Also push zstd:chunked compressed images #129
base: main
Are you sure you want to change the base?
Conversation
CC @castrojo :) |
Let's test this format with one image first and then copy it for all the others. |
😞 |
Thanks for the tag! cc @p5 One thing I learned is that many tutorials recommend The github public roadmap mentions that 24.04 builders should go out of beta this summer, so we figured it would just be best to roll it out the day after those go live or something after confirming that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Is the plan going to be to make both these images accessible under a single manifest (tag)?
This will allow a user to run podman pull <image>:stream9
and receive a zstd:chunked image if their container tooling supports it, or a gzipped image if it does not.
Additional required steps would be to (some details excluded):
- Push the gzipped image to a different tag
- Create a manifest (
podman manifest create <name>
) - Add each images to the manifest (
podman manifest add <name> <image>
) - Push the manifest to the registry under a stable tag (
podman manifest push <name> <image>:stream9
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a single tag would be #128 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know this was possible until today. I'll take a look. PRs also welcomed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be an awesome feature of redhat-actions/push-to-registry, although I seem to remember somebody saying this action isn't really something managed by RedHat themselves, but rather one or two people who happen to be at RedHat.
Docker requires you to supply the format as a build arg, so it's far more work.
Podman has it under push args, so it would be cool if the action could push these compression-specific images to a registry and build/push the manifest file to the tags we define as inputs. It would make it so much easier if everyone could just say compression-formats: gzip zstd:chunked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created an action that does just this for ublue. The implementation is quite possibly one of the worst things I have ever created, but it does the job.
https://github.com/ublue-os/push-to-registry/tree/scaffold-repository
You define compression-formats: gzip zstd:chunked
, it pushes <image>:<tag>-gzip
and <image>:<tag>-zstd-chunked
to the registry. It then builds the manifest with the required annotations before pushing it to the registry
I'm not suggesting you use my action. Quite the opposite - it would be best if there was a "supported" way of doing this in the existing push-to-registry action. And my module can be an example of the complexity required to DIY this, hopefully justifying the need for improved support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to using your action until we find the time to push this upstream in redhat-actions/push-to-registry. Maybe I can take look as I have made some patches to that project before redhat-actions/push-to-registry#90 that are still pending.
github/workflows: Use Ubuntu 24.04 runners
github/workflows/centos: Also push zstd:chunked compressed images
See: #128
See: https://fedoraproject.org/wiki/Changes/zstd:chunked
See: https://docs.podman.io/en/latest/markdown/podman-push.1.html#compression-format-gzip-zstd-zstd-chunked
See: coreos/fedora-coreos-tracker#1660