Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update toolchain to 1.84.1. apply clippy fixes & rustfmt #1026

Merged
merged 6 commits into from
Feb 3, 2025

Conversation

dsully
Copy link
Contributor

@dsully dsully commented Feb 1, 2025

What does this PR do

Updates rust-toolchain.toml to "stable" (currently 1.84.1) and runs clippy --fix + rustfmt

Standards checklist

  • The PR title is descriptive
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself
  • If this PR introduces new user-facing messages they are translated

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@SteveLauC
Copy link
Member

Updates rust-toolchain.toml to "stable"

I pinned it to the MSRV purposely to make packaging easier.

Is there any reason why you want to change it to the latest stable toolchain?

runs clippy --fix + rustfmt

Thanks for fixing the Clippy issue

@dsully
Copy link
Contributor Author

dsully commented Feb 2, 2025

Hi @SteveLauC - I have another PR that I've not put up yet that removes lazy_static and once_cell in favor of std::sync::LazyLock, which is why I wanted to bump the MSRV / toolchain version.

@SteveLauC
Copy link
Member

That sounds reasonable! 😄 Please pin the toolchain to the MSRV rather than "stable"

@SteveLauC SteveLauC changed the title chore: update to stable toolchain. apply clippy fixes & rustfmt chore: update toolchain to 1.84.1. apply clippy fixes & rustfmt Feb 2, 2025
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@SteveLauC SteveLauC merged commit 224bb96 into topgrade-rs:main Feb 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants