Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changeset guidelines #4510

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Update changeset guidelines #4510

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
51c05d9
Update changeset file
AdrianContiu Aug 27, 2024
ab59e5a
Fix typo
AdrianContiu Aug 27, 2024
6c212c1
Fix message structure
AdrianContiu Aug 27, 2024
14b3a2e
Update changeset guidelines
AdrianContiu Sep 5, 2024
86d10c7
Merge 'master' in upd-changeset-guidelines
AdrianContiu Sep 5, 2024
e73a2f7
Reformulate the changeset message
AdrianContiu Sep 5, 2024
93d8aa0
Insert note icon
AdrianContiu Oct 7, 2024
6d96d3c
Merge 'master' in upd-changeset-guidelines
AdrianContiu Oct 7, 2024
bf7019f
Address review comments
AdrianContiu Oct 8, 2024
465c9a6
Merge 'master' in upd-changeset-guidelines
AdrianContiu Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/contribution/changeset-guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ Please use this format:
```
---
'@toptal/[package]': [version bump]
//if the build bump is major, please also add the line below to have the changeset comments visible in the Picasso patch release notes.
'@toptal/picasso': patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this comment will always be visible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct! :)
I've changed it, Thx!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the https://github.com/toptal/picasso/blob/master/packages/topkit-analytics-charts/package.json is bumped, we do not need to bump @toptal/picasso as it does not depend on it. Should there be some kind of specification that @toptal/picasso should be bumped not in 100% if cases (as @toptal/picasso does not depend on all packages in https://github.com/toptal/picasso)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also mention, that when we add the patch for Picasso, we should also include the heading for giving context in the Picasso release notes

---

---
Expand Down
Loading