-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support#457: Add Flightpath #871
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #871 +/- ##
==========================================
- Coverage 52.86% 52.12% -0.74%
==========================================
Files 163 168 +5
Lines 7856 7977 +121
Branches 175 175
==========================================
+ Hits 4153 4158 +5
- Misses 3577 3693 +116
Partials 126 126 ☔ View full report in Codecov by Sentry. |
390df23
to
5035ec0
Compare
Hey @BrianXu20 With my limited knowledge here the script looks OK. I think Kevin H may be the person to contact about testing etc. he has helped me with circle CI on this project recently. |
1 similar comment
Hey @BrianXu20 With my limited knowledge here the script looks OK. I think Kevin H may be the person to contact about testing etc. he has helped me with circle CI on this project recently. |
I have tested this is working on my local machine, and it copied the prod data directly.
|
I have tested this is working on my local machine,
|
0af3ef2
to
2f32d87
Compare
The latest changes you made look good. |
4af4415
to
7c18275
Compare
Looks good except for the bit about Suggestion: Birdbath is using version 0.0.5, I would suggest upgrading it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for the bit about HerokuAnonymisationAllowedCheck. I suggest removing that. Also the bit about fake email address being too realistic.
Suggestion: Birdbath is using version 0.0.5, I would suggest upgrading it to django-birdbath = "^1.0.0".
d14b85f
to
6b49711
Compare
e425b5c
to
0c505ff
Compare
3894a28
to
edd51d9
Compare
12bbd0b
to
f22d3b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a tricky one!
I'm not sure if it is necessarily a problem but I noticed that running birdbath more than once on dev data throws an error. I got Exception: [IntegrityError('duplicate key value violates unique constraint "auth_group_name_key"\nDETAIL: Key (name)=(Student: joshua.good-0) already exists.\n')]
f22d3b8
to
0570c34
Compare
9b0bb05
to
22fb1c9
Compare
6cdc61e
to
bf837a9
Compare
This reverts commit ceef4d1.
This reverts commit 7aa217e.
Include personal data in the student pages, groups and collections
Co-authored-by: rachelhsmith <[email protected]>
bf837a9
to
5b0ee5e
Compare
Ticket: https://torchbox.monday.com/boards/1343847472/pulses/1343866317
This adds Flightpath to allow copy production data to development and also adds some new processors.
Birdbath:
Flightpath:
Heroku:
Production
Development
Audit Site: (custom processors)
Docs:
Tasks: