Skip to content

Commit

Permalink
Merge pull request #356 from colemanw/noMaxlength
Browse files Browse the repository at this point in the history
ConvertEntity - Don't write maxlength, it's redundant
  • Loading branch information
totten authored Sep 16, 2024
2 parents a4af293 + 5d9bffa commit 4625e96
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/CRM/CivixBundle/Command/ConvertEntityCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,6 @@ private static function getFieldsFromXml($xml, $thisTables): array {
}
$attributes = isset($fieldXml->html) ? self::snakeCaseKeys((array) $fieldXml->html) : [];
unset($attributes['type']);
if (!empty($typeAttributes['length'])) {
$attributes['maxlength'] = (int) $typeAttributes['length'];
}
// Fix if xml erroneously includes multiple labels
if (!empty($attributes['label']) && !is_string($attributes['label'])) {
$attributes['label'] = ((array) $attributes['label'])[0];
Expand Down

0 comments on commit 4625e96

Please sign in to comment.