Solving todos about getting hold of semaphores and editing error mess…

…ages accordingly
tpiekarski · May 13, 2020 · 3efbfb7 · 3efbfb7
1 parent 4cd9db3
commit 3efbfb7
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/lkm_mev.c b/lkm_mev.c
@@ -310,9 +310,8 @@ static ssize_t mev_read(struct file *file, char __user *buf, size_t count,
 	ssize_t retval = 0;
 
 	if (down_interruptible(&container->sem)) {
-		// todo: check why is 'out' not used (maybe use it)?
-		printk(KERN_DEBUG
-		       "%s: - (down_interruptible(&container->sem)) = true\n",
+		printk(KERN_ERR
+		       "%s: Failed getting hold of the semaphore by calling interruptible down\n",
 		       THIS_MODULE->name);
 
 		return -ERESTARTSYS;
@@ -438,9 +437,8 @@ static ssize_t mev_write(struct file *file, const char __user *buf,
 	ssize_t retval = -ENOMEM;
 
 	if (down_interruptible(&container->sem)) {
-		// todo: check why is 'out' not used (maybe use it)?
-		printk(KERN_DEBUG
-		       "%s: - (down_interruptible(&container->sem)) = true\n",
+		printk(KERN_ERR
+		       "%s: Failed getting hold of the semaphore by calling interruptible down\n",
 		       THIS_MODULE->name);
 
 		return -ERESTARTSYS;