test: ensure that simulator processes are terminated/killed #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems that we leak simulator processes if the simulator is not ready within about one second, so kill the subprocess if it's not ready. Also ensure the simulator is killed in test teardown to avoid building up a set of processes which might slow down the build. This should solve the issue where the parts of the CI flow which run after the tests runs very slow which is due to swtpm processes running in the background using the CPU and only leaving ~10% of the CPU to the CI processes. Signed-off-by: Erik Larsson <[email protected]>
williamcroberts
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that we leak simulator processes if the simulator is not ready within about one second, so kill the subprocess if it's not ready.
Also ensure the simulator is killed in test teardown to avoid building up a set of processes which might slow down the build.
This should solve the issue where the parts of the CI flow which run after the tests runs very slow which is due to swtpm processes running in the background using the CPU and only leaving ~10% of the CPU to the CI processes.
Related to #381