ESYS: Support of Cp and RpHashes from Esys Layer #2932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuergenReppSIT
force-pushed
the
esys-cp-rp-hash-functions
branch
6 times, most recently
from
cf151c6 to
9d9ffc1
Compare
JuergenReppSIT
force-pushed
the
esys-cp-rp-hash-functions
branch
from
1486a77 to
1bbdf2c
Compare
JuergenReppSIT
force-pushed
the
esys-cp-rp-hash-functions
branch
11 times, most recently
from
65cfea1 to
0e3085c
Compare
JuergenReppSIT
force-pushed
the
esys-cp-rp-hash-functions
branch
2 times, most recently
from
3647305 to
965c6dd
Compare
JuergenReppSIT
force-pushed
the
esys-cp-rp-hash-functions
branch
2 times, most recently
from
9b3d480 to
8256d4d
Compare
JuergenReppSIT
force-pushed
the
esys-cp-rp-hash-functions
branch
from
8256d4d to
c0cb3b7
Compare
JuergenReppSIT
force-pushed
the
esys-cp-rp-hash-functions
branch
2 times, most recently
from
625602d to
e61470a
Compare
The function is added to reset the internal state to enable a second prepare call without finishing the complete sequence of sys calls. Signed-off-by: Juergen Repp <[email protected]>
The CP buffer should still be available before Tss2_ExecuteFinish is called. Signed-off-by: Juergen Repp <[email protected]>
The ESYS API is extended with the functions: Esys_GetCpHash, Esys_GetRpHash, and Esys_Abort. The cp hash can computed after the async call of a function. The rp hash after the finish call. If only the async call is executed to to compute the cp hash Esys_Abort has to be called to enable the execution of further ESYS commands. Addresses: tpm2-software#2930. Signed-off-by: Juergen Repp <[email protected]>
JuergenReppSIT
force-pushed
the
esys-cp-rp-hash-functions
branch
from
e61470a to
ef07be1
Compare
lib/tss2-tcti-null.pc.in
Outdated
| includedir=@includedir@ | ||
|
|
||
| Name: tss2-tcti-null | ||
| Description: TCTI library for debugging at the TCTI interface. |
There was a problem hiding this comment.
This description does not quite fit the purpose
src/tss2-esys/esys_cp_rp_hash.c
Outdated
| r = Esys_GetSysContext(esys_ctx, &sys_ctx); | ||
| return_if_error(r, "Could not get Sys context"); | ||
|
|
||
| return Tss2_Sys_Abort(sys_ctx); |
There was a problem hiding this comment.
I would first execute Tss2_Sys_Abort and only if that succeeds we set the state to ESYS_STATE_INIT.
| size_t size, | ||
| const uint8_t *cmd_buf) | ||
| { | ||
| UNUSED(tcti_ctx); |
There was a problem hiding this comment.
I would add a LOG_WARNING to each of these null calls so that the user knows something is weird here.
AndreasFuchsTPM
requested changes
Feb 10, 2025
JuergenReppSIT
force-pushed
the
esys-cp-rp-hash-functions
branch
from
ef07be1 to
0759964
Compare
A tcti module which can only used for tcti initialization is added. Signed-off-by: Juergen Repp <[email protected]>
JuergenReppSIT
force-pushed
the
esys-cp-rp-hash-functions
branch
from
0759964 to
1b12e09
Compare
AndreasFuchsTPM
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esys_GetCpHash, Esys_GetRpHash, and Esys_Abort.
The cp hash can computed after the async call of a function. The rp hash
after the finish call. If only the async call is executed to to compute the cp hash
Esys_Abort has to be called to enable the execution of further ESYS commands.
Addresses: #2930.