Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the default feature from cubecl-hip-sys Cargo.toml #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove the default feature from cubecl-hip-sys Cargo.toml #13

wants to merge 3 commits into from

Conversation

syl20bnr
Copy link
Member

The default feature to select a default version of ROCm prevents users from easily choosing a different version in Burn.

Part of the fix for Burn discussion tracel-ai/burn#2709

@syl20bnr syl20bnr requested a review from laggui January 17, 2025 20:45
laggui
laggui approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Missing the default version for CI it looks, but I'll approve in advance 🙂

I'll have to fix the (incorrect) default feature additivity on the Burn side.

@syl20bnr syl20bnr force-pushed the fix/default-feature branch from 47155b2 to e46f544 Compare January 17, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laggui laggui laggui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syl20bnr @laggui