Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean stage again #471

Merged
merged 9 commits into from
Feb 7, 2025
Merged

Clean stage again #471

merged 9 commits into from
Feb 7, 2025

Conversation

maxtremblay
Copy link
Collaborator

@maxtremblay maxtremblay commented Feb 7, 2025

  • Uniformize many names and clarify some short (or wrong) names.
    • Use tile_count with either the m, n and k axes or the row and col axes
      for the number of tiles within a stage.
    • Use tile_shape for the shape of a tile.
    • Use tile_size for the total number of elements in a tile. The product of all shape of a time.
  • Introduce a new concept of StageTiling that replace many previously used traits and structs related to tiling. A CompleteStageTiling is able to work with both the mnk axes and the row-col axes.
  • Remove a few now unused traits, structs and functions.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Missed a docstring, but approving in advance.

crates/cubecl-linalg/src/matmul/components/stage/base.rs Outdated Show resolved Hide resolved
@maxtremblay maxtremblay merged commit 16dc53a into main Feb 7, 2025
5 checks passed
@maxtremblay maxtremblay deleted the clean-stage-again branch February 7, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants