Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump burn: 0.13.0 -> 0.16.0 #57

Merged

Conversation

HerrMuellerluedenscheid
Copy link
Contributor

Fixes issue mentioned here: tracel-ai/burn#2845 (comment)

@HerrMuellerluedenscheid
Copy link
Contributor Author

This fixes the example using feature: weight_embeded. However I'm running into the following error when using feature weights_file:

thread 'main' panicked at /Users/mariuskriegerowski/src/rust/burn-models/squeezenet-burn/target/release/build/squeezenet-burn-7fe83ccf42e0f30c/out/model/squeezenet1.rs:67:14:
Record file to exist.: Unknown("Unable to load record.\nMetadata has a different float type: Actual \"half::binary16::f16\", Expected \"f32\"\nMetadata has a different int type: Actual \"i16\", Expected \"i32\"\nMetadata has a different format: Actual \"burn_core::record::file::NamedMpkGzFileRecorder<burn_core::record::settings::HalfPrecisionSettings>\", Expected \"burn_core::record::file::NamedMpkFileRecorder<burn_core::record::settings::FullPrecisionSettings>\"\nMetadata has a different Burn version: Actual \"0.13.2\", Expected \"0.16.0\"\nError: Unknown(\"Syntax(\\\"missing field `bytes`\\\")\\nThe internal data format has changed since version 0.14.0. If you are trying to load a record saved in a previous version, use the `record-backward-compat` feature flag. Once you have saved the record in the new format, you can disable the feature flag.\\n\")")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Not sure, yet what the issue is. Hints are appreciated :)

@antimora
Copy link
Collaborator

@HerrMuellerluedenscheid try cleaning the build like cargo clean. It's trying to load model for the previous version.

@HerrMuellerluedenscheid
Copy link
Contributor Author

@HerrMuellerluedenscheid try cleaning the build like cargo clean. It's trying to load model for the previous version.

Thanks! yeah, don't know why I didn't do that. That fixed it :)

So, this is ready. I separated the actual bugfix in #58 but actually now you can also merge this and have both fixed together. As you like.

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for upgrading and fixing the issues.

@antimora
Copy link
Collaborator

I will merge once the CI passes.

@antimora antimora merged commit 0825397 into tracel-ai:main Feb 27, 2025
2 checks passed
@laggui laggui mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants