Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(langchain): various bugs and edge cases in metric exporting #2167

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix(langchain): various bugs and edge cases in metric exporting #2167

merged 1 commit into from
Oct 17, 2024

Conversation

nirga
Copy link
Member

@nirga nirga commented Oct 17, 2024 •
edited
Loading

Addresses some of the issues in #2166

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 17, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working python Pull requests that update Python code and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 17, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 17, 2024
@nirga nirga merged commit d101bbb into main Oct 17, 2024
9 checks passed
@nirga nirga deleted the lc-metric-fix branch October 17, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VadimZaporozhets VadimZaporozhets VadimZaporozhets approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nirga @VadimZaporozhets