Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump golangci-lint and fix config #1680

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

mvertes
Copy link
Member

@mvertes mvertes commented Jan 8, 2025

This fixes the CI lint step. No change in code except a small fix in test output.

This fixes the CI lint step. No change in code except a fix
in test output.
@mvertes mvertes requested a review from mloiseleur January 8, 2025 09:59
@mloiseleur
Copy link

mloiseleur commented Jan 8, 2025

@mvertes It fails on an other test with TestInterpErrorConsistency/switch13.go. I launched it again, same result.

Error:     interp_consistent_test.go:355: got "# command-line-arguments\n../_test/switch13.go:9:7: i is not a type\n", want: "9:7: i (variable of type interface{}) is not a type"

@mvertes
Copy link
Member Author

mvertes commented Jan 8, 2025

I will fix the test prior merging. This is due to compiler error format change in the last versions of Go.

@mvertes mvertes merged commit 14d3137 into traefik:master Jan 8, 2025
12 checks passed
@mvertes mvertes deleted the golangci-lint branch January 8, 2025 11:01
@mvertes mvertes added this to the v0.16.x milestone Jan 8, 2025
@mvertes mvertes added bug Something isn't working area/infrastructure labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infrastructure bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants