Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/popular lists #421

Merged
merged 9 commits into from
Feb 10, 2025
Merged

Feat/popular lists #421

merged 9 commits into from
Feb 10, 2025

Conversation

seferturan
Copy link
Collaborator

🎶 Notes 🎶

  • Adds a popular lists section in the show and movie summary pages.
  • Viewing the lists will be a follow up PR.
  • Loading/empty state also needs to be followed up:
    • Performance was not good enough to fetch the lists while requesting the rest of the summary data.
    • For now placed at the bottom to reduce the annoyance of possible content jumps.

👀 Examples 👀

Screenshot 2025-02-10 at 00 34 35 Screenshot 2025-02-10 at 00 35 06

Copy link

deepsource-io bot commented Feb 9, 2025

Here's the code health analysis summary for commits 14d5287..671439d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateJavascript
Branch Coverage26.7% (down 0.1% from main)26.7% (down 0.1% from main)
Composite Coverage61.3%61.3%
Line Coverage73.1% (down 0.1% from main)73.1% (down 0.1% from main)

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@seferturan seferturan requested a review from vladjerca February 9, 2025 23:53
@seferturan seferturan force-pushed the feat/popular_lists branch 3 times, most recently from 18d1014 to f925de6 Compare February 10, 2025 16:19
@seferturan seferturan merged commit 9d59b42 into main Feb 10, 2025
9 checks passed
@seferturan seferturan deleted the feat/popular_lists branch February 10, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants