use Println instead of Printf when possible

cmd/lakectl/cmd/abuse_commit.go

@@ -26,7 +26,7 @@ var abuseCommitCmd = &cobra.Command{
 		amount := Must(cmd.Flags().GetInt("amount"))
 		gapDuration := Must(cmd.Flags().GetDuration("gap"))
 
-		fmt.Printf("Source branch: %s\n", u)
+		fmt.Println("Source branch:", u)
 
 		generator := stress.NewGenerator("commit", 1, stress.WithSignalHandlersFor(os.Interrupt, syscall.SIGTERM))
 

cmd/lakectl/cmd/abuse_create_branches.go

@@ -29,7 +29,7 @@ var abuseCreateBranchesCmd = &cobra.Command{
 
 		client := getClient()
 
-		fmt.Printf("Source ref: %s\n", u)
+		fmt.Println("Source ref:", u)
 		deleteGen := stress.NewGenerator("delete branch", parallelism)
 
 		const paginationAmount = 1000

cmd/lakectl/cmd/abuse_link_same_object.go

@@ -24,8 +24,8 @@ var abuseLinkSameObjectCmd = &cobra.Command{
 		parallelism := Must(cmd.Flags().GetInt("parallelism"))
 		key := Must(cmd.Flags().GetString("key"))
 
-		fmt.Printf("Source ref: %s\n", u)
-		fmt.Printf("Object key: %s\n", key)
+		fmt.Println("Source ref:", u)
+		fmt.Println("Object key:", key)
 
 		generator := stress.NewGenerator("get-and-link", parallelism, stress.WithSignalHandlersFor(os.Interrupt, syscall.SIGTERM))
 

cmd/lakectl/cmd/abuse_random_read.go

@@ -27,7 +27,7 @@ var abuseRandomReadsCmd = &cobra.Command{
 		parallelism := Must(cmd.Flags().GetInt("parallelism"))
 		fromFile := Must(cmd.Flags().GetString("from-file"))
 
-		fmt.Printf("Source ref: %s\n", u)
+		fmt.Println("Source ref:", u)
 		// read the input file
 		keys, err := readLines(fromFile)
 		if err != nil {

cmd/lakectl/cmd/abuse_random_writes.go

@@ -26,7 +26,7 @@ var abuseRandomWritesCmd = &cobra.Command{
 		parallelism := Must(cmd.Flags().GetInt("parallelism"))
 		prefix := Must(cmd.Flags().GetString("prefix"))
 
-		fmt.Printf("Source branch: %s\n", u)
+		fmt.Println("Source branch:", u)
 		generator := stress.NewGenerator("stage object", parallelism, stress.WithSignalHandlersFor(os.Interrupt, syscall.SIGTERM))
 
 		// generate randomly selected keys as input

cmd/lakectl/cmd/actions_runs_describe.go

@@ -31,7 +31,7 @@ var actionsRunsDescribeCmd = &cobra.Command{
 		u := MustParseRepoURI("repository", args[0])
 		pagination := api.Pagination{HasMore: true}
 
-		fmt.Printf("Repository: %s\n", u)
+		fmt.Println("Repository:", u)
 		runID := args[1]
 
 		client := getClient()

cmd/lakectl/cmd/branch_create.go

@@ -23,7 +23,7 @@ var branchCreateCmd = &cobra.Command{
 		if err != nil {
 			DieFmt("failed to parse source URI: %s", err)
 		}
-		fmt.Printf("Source ref: %s\n", sourceURI)
+		fmt.Println("Source ref:", sourceURI)
 		if sourceURI.Repository != u.Repository {
 			Die("source branch must be in the same repository", 1)
 		}

cmd/lakectl/cmd/branch_delete.go

@@ -20,7 +20,7 @@ var branchDeleteCmd = &cobra.Command{
 		}
 		client := getClient()
 		u := MustParseBranchURI("branch", args[0])
-		fmt.Printf("Branch: %s\n", u)
+		fmt.Println("Branch:", u)
 		resp, err := client.DeleteBranchWithResponse(cmd.Context(), u.Repository, u.Ref)
 		DieOnErrorOrUnexpectedStatusCode(resp, err, http.StatusNoContent)
 	},

cmd/lakectl/cmd/branch_reset.go

@@ -22,7 +22,7 @@ var branchResetCmd = &cobra.Command{
 	Run: func(cmd *cobra.Command, args []string) {
 		clt := getClient()
 		u := MustParseBranchURI("branch", args[0])
-		fmt.Printf("Branch: %s\n", u)
+		fmt.Println("Branch:", u)
 		prefix, err := cmd.Flags().GetString("prefix")
 		if err != nil {
 			DieErr(err)

cmd/lakectl/cmd/branch_revert.go

@@ -29,7 +29,7 @@ var branchRevertCmd = &cobra.Command{
 	},
 	Run: func(cmd *cobra.Command, args []string) {
 		u := MustParseBranchURI("branch", args[0])
-		fmt.Printf("Branch: %s\n", u)
+		fmt.Println("Branch:", u)
 		hasParentNumber := cmd.Flags().Changed(ParentNumberFlagName)
 		parentNumber := Must(cmd.Flags().GetInt(ParentNumberFlagName))
 		if hasParentNumber && parentNumber <= 0 {

cmd/lakectl/cmd/branch_show.go

@@ -16,14 +16,14 @@ var branchShowCmd = &cobra.Command{
 	Run: func(cmd *cobra.Command, args []string) {
 		client := getClient()
 		u := MustParseBranchURI("branch", args[0])
-		fmt.Printf("Branch: %s\n", u)
+		fmt.Println("Branch:", u)
 		resp, err := client.GetBranchWithResponse(cmd.Context(), u.Repository, u.Ref)
 		DieOnErrorOrUnexpectedStatusCode(resp, err, http.StatusOK)
 		if resp.JSON200 == nil {
 			Die("Bad response from server", 1)
 		}
 		branch := resp.JSON200
-		fmt.Printf("Commit ID: %s\n", branch.CommitId)
+		fmt.Println("Commit ID:", branch.CommitId)
 	},
 }
 

cmd/lakectl/cmd/cat_hook_output.go

@@ -18,7 +18,7 @@ var catHookOutputCmd = &cobra.Command{
 	ValidArgsFunction: ValidArgsRepository,
 	Run: func(cmd *cobra.Command, args []string) {
 		u := MustParseRepoURI("repository", args[0])
-		fmt.Printf("Repository: %s\n", u)
+		fmt.Println("Repository:", u)
 		runID := args[1]
 		hookRunID := args[2]
 		client := getClient()

cmd/lakectl/cmd/cherry_pick.go

@@ -28,7 +28,7 @@ var cherryPick = &cobra.Command{
 	Run: func(cmd *cobra.Command, args []string) {
 		ref := MustParseRefURI("ref", args[0])
 		branch := MustParseBranchURI("branch", args[1])
-		fmt.Printf("Branch: %s\n", branch)
+		fmt.Println("Branch:", branch)
 
 		if branch.Repository != ref.Repository {
 			Die("Repository mismatch for destination branch and cherry-pick ref", 1)

cmd/lakectl/cmd/commit.go

@@ -56,7 +56,7 @@ var commitCmd = &cobra.Command{
 		}
 
 		branchURI := MustParseRefURI("branch", args[0])
-		fmt.Printf("Branch: %s\n", branchURI)
+		fmt.Println("Branch:", branchURI)
 
 		// do commit
 		metadata := api.CommitCreation_Metadata{

cmd/lakectl/cmd/dbt_generate_schema_macro.go

@@ -38,7 +38,7 @@ generate_schema_name.sql
 		if err != nil {
 			DieErr(err)
 		}
-		fmt.Printf("macro created in path %s\n", macroPath)
+		fmt.Println("macro created in path", macroPath)
 	},
 }
 

cmd/lakectl/cmd/diff.go

@@ -54,7 +54,7 @@ var diffCmd = &cobra.Command{
 		if len(args) == diffCmdMinArgs {
 			// got one arg ref: uncommitted changes diff
 			branchURI := MustParseRefURI("ref", args[0])
-			fmt.Printf("Ref: %s\n", branchURI)
+			fmt.Println("Ref:", branchURI)
 			printDiffBranch(cmd.Context(), client, branchURI.Repository, branchURI.Ref)
 			return
 		}

cmd/lakectl/cmd/find_merge_base.go

@@ -36,7 +36,8 @@ var findMergeBaseCmd = &cobra.Command{
 		client := getClient()
 		sourceRef := MustParseRefURI("source ref", args[0])
 		destinationRef := MustParseRefURI("destination ref", args[1])
-		fmt.Printf("Source: %s\nDestination: %s\n", sourceRef, destinationRef)
+		fmt.Println("Source:", sourceRef)
+		fmt.Println("Destination:", destinationRef)
 		if destinationRef.Repository != sourceRef.Repository {
 			Die("both references must belong to the same repository", 1)
 		}

cmd/lakectl/cmd/import.go

@@ -91,7 +91,8 @@ var importCmd = &cobra.Command{
 		for {
 			select {
 			case <-sigCtx.Done():
-				fmt.Printf("\nCanceling import\n")
+				fmt.Println()
+				fmt.Println("Canceling import")
 				resp, err := client.ImportCancelWithResponse(ctx, toURI.Repository, toURI.Ref, &api.ImportCancelParams{Id: importID})
 				DieOnErrorOrUnexpectedStatusCode(resp, err, http.StatusNoContent)
 				Die("Import Canceled", 1)

cmd/lakectl/cmd/merge.go

@@ -38,7 +38,8 @@ var mergeCmd = &cobra.Command{
 		sourceRef := MustParseRefURI("source ref", args[0])
 		destinationRef := MustParseRefURI("destination ref", args[1])
 		strategy := Must(cmd.Flags().GetString("strategy"))
-		fmt.Printf("Source: %s\nDestination: %s\n", sourceRef, destinationRef)
+		fmt.Println("Source:", sourceRef)
+		fmt.Println("Destination:", destinationRef)
 		if destinationRef.Repository != sourceRef.Repository {
 			Die("both references must belong to the same repository", 1)
 		}

cmd/lakectl/cmd/metastore_diff.go

@@ -41,15 +41,15 @@ var metastoreDiffCmd = &cobra.Command{
 		} else {
 			fmt.Println("Columns")
 			for _, column := range diff.ColumnsDiff {
-				fmt.Printf("%s\n", column)
+				fmt.Println(column)
 			}
 		}
 		if len(diff.PartitionDiff) == 0 {
 			fmt.Println("Partitions are identical")
 		} else {
 			fmt.Println("Partitions")
 			for _, partition := range diff.PartitionDiff {
-				fmt.Printf("%s\n", partition)
+				fmt.Println(partition)
 			}
 		}
 	},

cmd/lakectl/cmd/refs_restore.go

@@ -26,7 +26,7 @@ Since a bare repo is expected, in case of transient failure, delete the reposito
 	Args:    cobra.ExactArgs(1),
 	Run: func(cmd *cobra.Command, args []string) {
 		repoURI := MustParseRepoURI("repository", args[0])
-		fmt.Printf("Repository: %s\n", repoURI)
+		fmt.Println("Repository:", repoURI)
 		manifestFileName := Must(cmd.Flags().GetString("manifest"))
 		fp := Must(OpenByPath(manifestFileName))
 		defer func() {

cmd/lakectl/cmd/repo_create.go

@@ -25,7 +25,7 @@ var repoCreateCmd = &cobra.Command{
 	Run: func(cmd *cobra.Command, args []string) {
 		clt := getClient()
 		u := MustParseRepoURI("repository", args[0])
-		fmt.Printf("Repository: %s\n", u)
+		fmt.Println("Repository:", u)
 		defaultBranch, err := cmd.Flags().GetString("default-branch")
 		if err != nil {
 			DieErr(err)

cmd/lakectl/cmd/repo_create_bare.go

@@ -20,7 +20,7 @@ var repoCreateBareCmd = &cobra.Command{
 	Run: func(cmd *cobra.Command, args []string) {
 		clt := getClient()
 		u := MustParseRepoURI("repository", args[0])
-		fmt.Printf("Repository: %s\n", u)
+		fmt.Println("Repository:", u)
 		defaultBranch, err := cmd.Flags().GetString("default-branch")
 		if err != nil {
 			DieErr(err)

cmd/lakectl/cmd/repo_delete.go

@@ -17,7 +17,7 @@ var repoDeleteCmd = &cobra.Command{
 	Run: func(cmd *cobra.Command, args []string) {
 		clt := getClient()
 		u := MustParseRepoURI("repository", args[0])
-		fmt.Printf("Repository: %s\n", u)
+		fmt.Println("Repository:", u)
 		confirmation, err := Confirm(cmd.Flags(), "Are you sure you want to delete repository: "+u.Repository)
 		if err != nil || !confirmation {
 			DieFmt("Delete Repository '%s' aborted\n", u.Repository)

cmd/lakectl/cmd/tag_create.go

@@ -24,7 +24,7 @@ var tagCreateCmd = &cobra.Command{
 	Run: func(cmd *cobra.Command, args []string) {
 		tagURI := MustParseRefURI("tag uri", args[0])
 		commitURI := MustParseRefURI("commit uri", args[1])
-		fmt.Printf("Tag ref: %s\n", tagURI)
+		fmt.Println("Tag ref:", tagURI)
 
 		client := getClient()
 		ctx := cmd.Context()

cmd/lakectl/cmd/tag_delete.go

@@ -19,7 +19,7 @@ var tagDeleteCmd = &cobra.Command{
 		}
 		client := getClient()
 		u := MustParseRefURI("tag", args[0])
-		fmt.Printf("Tag ref: %s\n", u)
+		fmt.Println("Tag ref:", u)
 
 		ctx := cmd.Context()
 		resp, err := client.DeleteTagWithResponse(ctx, u.Repository, u.Ref)