Shorter timeout for get bucket location #6295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
johnnyaug
added
exclude-changelog
| // calling `client.getBucketLocation(bucket)`. | ||
| if (region.equals(Region.US_Standard)) "us-east-1" | ||
| else region.toString | ||
| Region.fromValue(bucketRegion).toAWSRegion().getName() |
There was a problem hiding this comment.
What if region returns US Standard?
Will it still work?
There was a problem hiding this comment.
Yes, in this case:
- Region.fromValue will return
com.amazonaws.services.s3.model.Region.US_Standard. - Then, calling
toAWSRegionwill returnRegionUtils.getRegion("us-east-1").
There was a problem hiding this comment.
but then getName will return US again, no?
There was a problem hiding this comment.
No: from the docs of com.amazonaws.regions.Region:
The unique system ID for this region; ex: "us-east-1".
(also tested manually)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid long wait when GetBucketLocation is forbidden for the execution role.