Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove typesync from webui dev packages #8191

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Remove typesync from webui dev packages #8191

merged 2 commits into from
Sep 19, 2024

Conversation

arielshaqed
Copy link
Contributor

@arielshaqed arielshaqed commented Sep 19, 2024 •
edited
Loading

  1. devDependency so no effect on web UI.
  2. Never used AFAIK.
  3. Reduces number of package dependencies by >5% - less dependabot noise.

@arielshaqed
Remove typesync from webui dev packages
180aa7c 
1. devDependency so no effect on web UI.
1. Never used AFAIK.
1. Reduces number of package dependencies by >5% - less dependabot noise.
itaigilo
itaigilo approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@itaigilo itaigilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please!

(Seems like it's unused indeed, but just verifying - did you validate WebUI works after this removal, right?)

@arielshaqed arielshaqed added pr/merge-if-approved Reviewer: please feel free to merge if no major comments area/UI Improvements or additions to UI javascript Pull requests that update Javascript code tech-debt minor-change Used for PRs that don't require issue attached labels Sep 19, 2024
@arielshaqed
Copy link
Contributor Author

Yes, please!

(Seems like it's unused indeed, but just verifying - did you validate WebUI works after this removal, right?)

Indeed. Not too deeply, given that it's a dev dependency so never actually used, but web UI loads, creates sample repo, and even manages to run DuckDB on that repo.

@arielshaqed arielshaqed added the exclude-changelog PR description should not be included in next release changelog label Sep 19, 2024
@github-actions GitHub Actions
Copy link

E2E Test Results - Quickstart

10 passed

@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@arielshaqed
Copy link
Contributor Author

Thanks... auto-merging once tests pass.

@arielshaqed arielshaqed enabled auto-merge (squash) September 19, 2024 09:03
@arielshaqed
Copy link
Contributor Author

arielshaqed commented Sep 19, 2024 •
edited
Loading

I am @arielshaqed , I definitely have a CLA, and I'm an admin - so I will bypass the CLA check and force-pull this.

Actually just pushed an empty commit and everything passed 👼🏽

@arielshaqed arielshaqed merged commit 992c446 into master Sep 19, 2024
38 checks passed
@arielshaqed arielshaqed deleted the chore/remove-typesync branch September 19, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaigilo itaigilo itaigilo approved these changes

@guy-har guy-har Awaiting requested review from guy-har

Assignees
No one assigned
Labels
area/UI Improvements or additions to UI exclude-changelog PR description should not be included in next release changelog javascript Pull requests that update Javascript code minor-change Used for PRs that don't require issue attached pr/merge-if-approved Reviewer: please feel free to merge if no major comments tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielshaqed @itaigilo