Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test command termination error #378

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Test command termination error #378

merged 3 commits into from
Jan 22, 2025

Conversation

balanza
Copy link
Member

@balanza balanza commented Jan 20, 2025

Description

Adding some more tests on command execution

@balanza balanza requested review from arbulu89, CDimonaco and janvhs and removed request for arbulu89 January 20, 2025 14:59
arbulu89
arbulu89 reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @balanza
I think we could rewrite the error assertions in a more golang style. I just commented some few of them

pkg/utils/commandexecutor.go Show resolved Hide resolved
pkg/utils/commandexecutor_test.go Show resolved Hide resolved
pkg/utils/commandexecutor_test.go Outdated Show resolved Hide resolved
pkg/utils/commandexecutor_test.go Outdated Show resolved Hide resolved
pkg/utils/commandexecutor.go Outdated Show resolved Hide resolved
pkg/utils/commandexecutor_test.go Show resolved Hide resolved
@balanza balanza requested a review from arbulu89 January 20, 2025 23:06
arbulu89
arbulu89 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @balanza
Good job

pkg/utils/commandexecutor_test.go Outdated Show resolved Hide resolved
janvhs
janvhs approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@janvhs janvhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :D

@balanza balanza merged commit 25bc4a3 into main Jan 22, 2025
10 checks passed
@balanza balanza deleted the fix-error branch January 22, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvhs janvhs janvhs approved these changes

@arbulu89 arbulu89 arbulu89 approved these changes

@CDimonaco CDimonaco Awaiting requested review from CDimonaco

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balanza @arbulu89 @janvhs