Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle context cancellation in fact gatherers #384

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Conversation

balanza
Copy link
Member

@balanza balanza commented Jan 30, 2025

Description

Following #376, handle context cancellation in the following gatherers

  • corosyncconf
  • fstab
  • groups
  • hostsfile
  • osrelease
  • passwd
  • sapcontrol
  • sapinstancehostnameresolver
  • sapprofiles

@balanza balanza requested review from arbulu89 and CDimonaco January 30, 2025 19:34
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
Comments about the sapcontrol gatherer

internal/factsengine/gatherers/sapcontrol.go Show resolved Hide resolved
internal/factsengine/gatherers/sapcontrol.go Outdated Show resolved Hide resolved
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Thank you

@balanza balanza merged commit a61a9b0 into main Feb 5, 2025
11 checks passed
@balanza balanza deleted the other-gatherer branch February 5, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants